( )⚙ D11787 status: adapt the "keyword" extensions to gather stats at lookup time

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11787

status: adapt the "keyword" extensions to gather stats at lookup time
ClosedPublic

Authored by marmoute on Nov 24 2021, 6:12 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG4237be881bb6: status: adapt the "keyword" extensions to gather stats at lookup time
Summary

See main core code for details.

We don't factor the code in a common function yet, because we will have to adapt
a bit more things in the keyword case at the end of the series.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Nov 24 2021, 6:12 AM
Alphare requested changes to this revision.Nov 24 2021, 8:24 AM
Alphare added a subscriber: Alphare.

This is keyword, not largefiles

This revision now requires changes to proceed.Nov 24 2021, 8:24 AM
marmoute retitled this revision from status: adapt largefile to gather stats at lookup time to status: adapt the "keyword" extensions to gather stats at lookup time.Nov 30 2021, 6:53 PM
marmoute edited the summary of this revision. (Show Details)
Alphare accepted this revision.Dec 1 2021, 5:12 AM
This revision is now accepted and ready to land.Dec 1 2021, 5:12 AM

Revision Contents
Changeset List

PathPackages
Mhgext/keyword.py (9 lines)

Diff 31249

hgext/keyword.py

templatefilters, templatefilters,
templateutil, templateutil,
util, util,
) )
from mercurial.utils import ( from mercurial.utils import (
dateutil, dateutil,
stringutil, stringutil,
) )
from mercurial.dirstateutils import timestamp
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified. # leave the attribute unspecified.
testedwith = b'ships-with-hg-core' testedwith = b'ships-with-hg-core'
if self.restrict or rekw: if self.restrict or rekw:
re_kw = self.rekw re_kw = self.rekw
else: else:
re_kw = self.rekwexp re_kw = self.rekwexp
if expand: if expand:
msg = _(b'overwriting %s expanding keywords\n') msg = _(b'overwriting %s expanding keywords\n')
else: else:
msg = _(b'overwriting %s shrinking keywords\n') msg = _(b'overwriting %s shrinking keywords\n')
wctx = self.repo[None]
for f in candidates: for f in candidates:
if self.restrict: if self.restrict:
data = self.repo.file(f).read(mf[f]) data = self.repo.file(f).read(mf[f])
else: else:
data = self.repo.wread(f) data = self.repo.wread(f)
if stringutil.binary(data): if stringutil.binary(data):
continue continue
if expand: if expand:
else: else:
data, found = _shrinktext(data, re_kw.subn) data, found = _shrinktext(data, re_kw.subn)
if found: if found:
self.ui.note(msg % f) self.ui.note(msg % f)
fp = self.repo.wvfs(f, b"wb", atomictemp=True) fp = self.repo.wvfs(f, b"wb", atomictemp=True)
fp.write(data) fp.write(data)
fp.close() fp.close()
if kwcmd: if kwcmd:
self.repo.dirstate.set_clean(f) s = wctx[f].lstat()
mode = s.st_mode
size = s.st_size
mtime = timestamp.mtime_of(s)
cache_data = (mode, size, mtime)
self.repo.dirstate.set_clean(f, cache_data)
elif self.postcommit: elif self.postcommit:
self.repo.dirstate.update_file_p1(f, p1_tracked=True) self.repo.dirstate.update_file_p1(f, p1_tracked=True)
def shrink(self, fname, text): def shrink(self, fname, text):
'''Returns text with all keyword substitutions removed.''' '''Returns text with all keyword substitutions removed.'''
if self.match(fname) and not stringutil.binary(text): if self.match(fname) and not stringutil.binary(text):
return _shrinktext(text, self.rekwexp.sub) return _shrinktext(text, self.rekwexp.sub)
return text return text