( )⚙ D1178 show: move configitems to core

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1178

show: move configitems to core
ClosedPublic

Authored by quark on Oct 18 2017, 6:08 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG317566f0c2e6: show: move configitems to core
rHG2dd18a3fa69e: show: move configitems to core
Summary

chgserver.py is also checking the config and will get:

devel-warn: accessing unregistered config item:
'commands.show.aliasprefix' at:
mercurial/chgserver.py:109

if the config is not registered.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Oct 18 2017, 6:08 PM
quark edited the summary of this revision. (Show Details)Oct 18 2017, 6:08 PM
durin42 accepted this revision.Oct 18 2017, 6:14 PM
This revision is now accepted and ready to land.Oct 18 2017, 6:14 PM
Closed by commit rHG2dd18a3fa69e: show: move configitems to core (authored by quark). · Explain WhyOct 18 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/show.py (6 lines)
Mmercurial/configitems.py (3 lines)

Diff 3003

hgext/show.py

# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified. # leave the attribute unspecified.
testedwith = 'ships-with-hg-core' testedwith = 'ships-with-hg-core'
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
configtable = {}
configitem = registrar.configitem(configtable)
configitem('commands', 'show.aliasprefix',
default=list,
)
revsetpredicate = registrar.revsetpredicate() revsetpredicate = registrar.revsetpredicate()
class showcmdfunc(registrar._funcregistrarbase): class showcmdfunc(registrar._funcregistrarbase):
"""Register a function to be invoked for an `hg show <thing>`.""" """Register a function to be invoked for an `hg show <thing>`."""
# Used by _formatdoc(). # Used by _formatdoc().
_docformat = '%s -- %s' _docformat = '%s -- %s'

mercurial/configitems.py

generic=True, generic=True,
) )
coreconfigitem('color', 'mode', coreconfigitem('color', 'mode',
default='auto', default='auto',
) )
coreconfigitem('color', 'pagermode', coreconfigitem('color', 'pagermode',
default=dynamicdefault, default=dynamicdefault,
) )
coreconfigitem('commands', 'show.aliasprefix',
default=list,
)
coreconfigitem('commands', 'status.relative', coreconfigitem('commands', 'status.relative',
default=False, default=False,
) )
coreconfigitem('commands', 'status.skipstates', coreconfigitem('commands', 'status.skipstates',
default=[], default=[],
) )
coreconfigitem('commands', 'status.verbose', coreconfigitem('commands', 'status.verbose',
default=False, default=False,