This is an archive of the discontinued Mercurial Phabricator instance.

filemerge: stop passing around 3 unused `None` values in `files` argument
ClosedPublic

Authored by martinvonz on Dec 7 2021, 12:02 PM.

Details

Summary

Since 67cfffbfb6a0 (filemerge: eliminate most uses of tempfiles,
2017-08-31), we have used only the last entry in the files tuple
that gets passed around to various functions. That commit said
"Emphasize that they're unused so we can more easily remove them
later.". It's now "later".

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.