This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11883

directaccess: fix uses of commands.status() that don't go through flag parsing
ClosedPublic

Authored by spectral on Dec 7 2021, 6:57 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGc51408b92b88: directaccess: fix uses of commands.status() that don't go through flag parsing
Summary

When commands.commit.post-status is enabled, after commit/amend,
commands.status() is called without any revs argument, which means that status
gets None instead of an empty list like it would receive if the user had invoked
this on the commandline. With the experimental.directaccess config enabled,
this gets passed to unhidehashlikerevs, which didn't previously handle None,
but now should.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (3 lines)

Diff 31455

mercurial/scmutil.py

"""parse the user specs and unhide changesets whose hash or revision number """parse the user specs and unhide changesets whose hash or revision number
is passed. is passed.
hiddentype can be: 1) 'warn': warn while unhiding changesets hiddentype can be: 1) 'warn': warn while unhiding changesets
2) 'nowarn': don't warn while unhiding changesets 2) 'nowarn': don't warn while unhiding changesets
returns a repo object with the required changesets unhidden returns a repo object with the required changesets unhidden
""" """
if not specs:
return repo
if not repo.filtername or not repo.ui.configbool( if not repo.filtername or not repo.ui.configbool(
b'experimental', b'directaccess' b'experimental', b'directaccess'
): ):
return repo return repo
if repo.filtername not in (b'visible', b'visible-hidden'): if repo.filtername not in (b'visible', b'visible-hidden'):
return repo return repo