This is an archive of the discontinued Mercurial Phabricator instance.

directaccess: fix uses of commands.status() that don't go through flag parsing
ClosedPublic

Authored by spectral on Dec 7 2021, 6:57 PM.

Details

Summary

When commands.commit.post-status is enabled, after commit/amend,
commands.status() is called without any revs argument, which means that status
gets None instead of an empty list like it would receive if the user had invoked
this on the commandline. With the experimental.directaccess config enabled,
this gets passed to unhidehashlikerevs, which didn't previously handle None,
but now should.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.