Page MenuHomePhabricator

status: when extracting arguments from `opts`, use the same default values
ClosedPublic

Authored by spectral on Dec 7 2021, 6:57 PM.

Details

Summary

Sometimes other code, such as commit when using commands.commit.post-status,
calls commands.status() without going through the normal dispatch mechanism
that would typically fill in the args to be something besides None. As a
"defense in depth" mechanism for a bug where Mercurial would crash if both
commands.commit.post-status and experimental.directaccess were enabled,
let's sanitize these values to be identical to the values they would have when
the user invoked this method from the commandline.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Dec 7 2021, 6:57 PM
Alphare accepted this revision.Dec 13 2021, 9:24 AM
This revision is now accepted and ready to land.Dec 13 2021, 9:24 AM