Page MenuHomePhabricator

blackbox: change year in logs to ISO 8601 format
ClosedPublic

Authored by valentin.gatienbaron on Jan 18 2022, 12:45 AM.

Details

Summary

AFAIK, year/month/day is not a format than anyone uses. It seems more
sensible to me to use ISO 8601, as that's standard and unambiguously
year-month-day.

Compatibility-wise, I think it's acceptable to change the default
format. It's most for human consumption. It's plausible that a few
tools parse this format, but it has already changed in the past (for
instance to add the current revision).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare requested changes to this revision.Jan 18 2022, 4:02 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
hgext/blackbox.py
230–234

This comment should be updated to reflect the newly expected format

This revision now requires changes to proceed.Jan 18 2022, 4:02 AM
valentin.gatienbaron marked an inline comment as done.Jan 18 2022, 9:05 PM
Alphare accepted this revision.Jan 19 2022, 4:47 AM

Thanks!

This revision is now accepted and ready to land.Jan 19 2022, 4:47 AM

This broke test-rhg.t, I'll amend your change to fix it.

https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/283364