( )⚙ D12166 rhg: Add parsing for the --color global CLI argument

This is an archive of the discontinued Mercurial Phabricator instance.

rhg: Add parsing for the --color global CLI argument
ClosedPublic

Authored by SimonSapin on Feb 10 2022, 2:18 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Feb 10 2022, 2:18 PM
Alphare accepted this revision.Feb 12 2022, 6:29 PM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
rust/hg-core/src/config/layer.rs
307–308

This TODO is out-of-date now

This revision is now accepted and ready to land.Feb 12 2022, 6:29 PM
SimonSapin added inline comments.Feb 13 2022, 5:30 AM
rust/hg-core/src/config/layer.rs
307–308

Right, I’ll remove the CLI one.

The others may still be relevant. Maybe not defaults if we keep the current pattern of .get(…).unwrap_or(default_value) at use sites instead of centralized defaults definition.

Alphare added inline comments.Feb 13 2022, 5:53 AM
rust/hg-core/src/config/layer.rs
307–308

I think the others are still relevant. We should think about configitems.py at some point, so let's keep it.

SimonSapin updated this revision to Diff 32152.Feb 13 2022, 6:06 AM
This revision was automatically updated to reflect the committed changes.