( )⚙ D12223 cext: unconditionally use PyLong_FromLong()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12223

cext: unconditionally use PyLong_FromLong()
ClosedPublic

Authored by indygreg on Mar 1 2022, 7:21 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG9b0f173445d1: cext: unconditionally use PyLong_FromLong()
Summary

We no longer support Python 2.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 1 2022, 7:21 PM
Alphare accepted this revision.Mar 2 2022, 5:14 AM
This revision is now accepted and ready to land.Mar 2 2022, 5:14 AM
indygreg added a commit: rHG9b0f173445d1: cext: unconditionally use PyLong_FromLong().Mar 2 2022, 7:41 AM
Closed by commit rHG9b0f173445d1: cext: unconditionally use PyLong_FromLong() (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/dirs.c (4 lines)

Diff 32298

mercurial/cext/dirs.c

val = PyDict_GetItem(dirs, key); val = PyDict_GetItem(dirs, key);
if (val != NULL) { if (val != NULL) {
PYLONG_VALUE(val) += 1; PYLONG_VALUE(val) += 1;
Py_CLEAR(key); Py_CLEAR(key);
break; break;
} }
/* Force Python to not reuse a small shared int. */ /* Force Python to not reuse a small shared int. */
#ifdef IS_PY3K
val = PyLong_FromLong(0x1eadbeef); val = PyLong_FromLong(0x1eadbeef);
#else
val = PyInt_FromLong(0x1eadbeef);
#endif
if (val == NULL) if (val == NULL)
goto bail; goto bail;
PYLONG_VALUE(val) = 1; PYLONG_VALUE(val) = 1;
ret = PyDict_SetItem(dirs, key, val); ret = PyDict_SetItem(dirs, key, val);
Py_DECREF(val); Py_DECREF(val);
if (ret == -1) if (ret == -1)