( )⚙ D12234 tests: require Python 3.5+ in run-tests.py

This is an archive of the discontinued Mercurial Phabricator instance.

tests: require Python 3.5+ in run-tests.py
ClosedPublic

Authored by indygreg on Mar 1 2022, 7:34 PM.

Details

Summary

We change the version check logic to hard fail if running on
<= 3.5.0. The branch for <3.5 has been deleted. And the >=3.5
branch block has been dedented.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 1 2022, 7:34 PM
Alphare requested changes to this revision.Mar 2 2022, 5:28 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
tests/run-tests.py
158

This should be as high up as possible in the file

This revision now requires changes to proceed.Mar 2 2022, 5:28 AM
indygreg added inline comments.Mar 2 2022, 10:31 AM
tests/run-tests.py
158

Fun fact: that's how I initially coded this patch. However, some linter (check-imports I think) was complaining. I decided not to think about it too much and just leave the version check near where it was.

I just authored D12259 to fix this. I placed it at the end of the series to avoid rebase conflicts and having to resubmit a lot of diffs.

This depends on the series starting at D12218 since it would break the CI before some changes are made in the images handling early next week. See explanation in the link.

tests/run-tests.py
158

Fine with me, thanks!

This depends on the series starting at D12218 since it would break the CI before some changes are made in the images handling early next week. See explanation in the link.

The series has been rebased off the black series and should apply cleanly on @ now.

This revision was not accepted when it landed; it landed in state Needs Revision.
This revision was automatically updated to reflect the committed changes.