| Alphare |
| hg-reviewers |
Now that we no longer support Python 2, we should be able to import and
use the Python 3 only modules in our code. So remove a lint banning this.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | contrib/check-code.py (18 lines) |
| # XXX only catch mutable arguments on the first line of the definition | # XXX only catch mutable arguments on the first line of the definition | ||||
| (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"), | (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"), | ||||
| (r'\butil\.Abort\b', "directly use error.Abort"), | (r'\butil\.Abort\b', "directly use error.Abort"), | ||||
| ( | ( | ||||
| r'^@(\w*\.)?cachefunc', | r'^@(\w*\.)?cachefunc', | ||||
| "module-level @cachefunc is risky, please avoid", | "module-level @cachefunc is risky, please avoid", | ||||
| ), | ), | ||||
| ( | ( | ||||
| r'^import Queue', | |||||
| "don't use Queue, use pycompat.queue.Queue + " | |||||
| "pycompat.queue.Empty", | |||||
| ), | |||||
| ( | |||||
| r'^import cStringIO', | |||||
| "don't use cStringIO.StringIO, use util.stringio", | |||||
| ), | |||||
| (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"), | |||||
| ( | |||||
| r'^import SocketServer', | |||||
| "don't use SockerServer, use util.socketserver", | |||||
| ), | |||||
| (r'^import urlparse', "don't use urlparse, use util.urlreq"), | |||||
| (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), | |||||
| (r'^import httplib', "don't use httplib, use util.httplib"), | |||||
| (r'^import BaseHTTPServer', "use util.httpserver instead"), | |||||
| ( | |||||
| r'^(from|import) mercurial\.(cext|pure|cffi)', | r'^(from|import) mercurial\.(cext|pure|cffi)', | ||||
| "use mercurial.policy.importmod instead", | "use mercurial.policy.importmod instead", | ||||
| ), | ), | ||||
| (r'\.next\(\)', "don't use .next(), use next(...)"), | (r'\.next\(\)', "don't use .next(), use next(...)"), | ||||
| ( | ( | ||||
| r'([a-z]*).revision\(\1\.node\(', | r'([a-z]*).revision\(\1\.node\(', | ||||
| "don't convert rev to node before passing to revision(nodeorrev)", | "don't convert rev to node before passing to revision(nodeorrev)", | ||||
| ), | ), | ||||