( )⚙ D12284 check-code: allow importing Python 3 modules

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12284

check-code: allow importing Python 3 modules
ClosedPublic

Authored by indygreg on Mar 2 2022, 6:29 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG82f1c46cce5c: check-code: allow importing Python 3 modules
Summary

Now that we no longer support Python 2, we should be able to import and
use the Python 3 only modules in our code. So remove a lint banning this.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 2 2022, 6:29 PM
Alphare accepted this revision.Mar 3 2022, 4:56 AM
This revision is now accepted and ready to land.Mar 3 2022, 4:56 AM
indygreg added a commit: rHG82f1c46cce5c: check-code: allow importing Python 3 modules.Mar 3 2022, 11:51 AM
Closed by commit rHG82f1c46cce5c: check-code: allow importing Python 3 modules (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (18 lines)

Diff 32409

contrib/check-code.py

# XXX only catch mutable arguments on the first line of the definition # XXX only catch mutable arguments on the first line of the definition
(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"), (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
(r'\butil\.Abort\b', "directly use error.Abort"), (r'\butil\.Abort\b', "directly use error.Abort"),
( (
r'^@(\w*\.)?cachefunc', r'^@(\w*\.)?cachefunc',
"module-level @cachefunc is risky, please avoid", "module-level @cachefunc is risky, please avoid",
), ),
( (
r'^import Queue',
"don't use Queue, use pycompat.queue.Queue + "
"pycompat.queue.Empty",
),
(
r'^import cStringIO',
"don't use cStringIO.StringIO, use util.stringio",
),
(r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
(
r'^import SocketServer',
"don't use SockerServer, use util.socketserver",
),
(r'^import urlparse', "don't use urlparse, use util.urlreq"),
(r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),
(r'^import httplib', "don't use httplib, use util.httplib"),
(r'^import BaseHTTPServer', "use util.httpserver instead"),
(
r'^(from|import) mercurial\.(cext|pure|cffi)', r'^(from|import) mercurial\.(cext|pure|cffi)',
"use mercurial.policy.importmod instead", "use mercurial.policy.importmod instead",
), ),
(r'\.next\(\)', "don't use .next(), use next(...)"), (r'\.next\(\)', "don't use .next(), use next(...)"),
( (
r'([a-z]*).revision\(\1\.node\(', r'([a-z]*).revision\(\1\.node\(',
"don't convert rev to node before passing to revision(nodeorrev)", "don't convert rev to node before passing to revision(nodeorrev)",
), ),