This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12300

util: remove superfluous ispy3 test
ClosedPublic

Authored by indygreg on Mar 2 2022, 6:30 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG10839394f39b: util: remove superfluous ispy3 test

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 2 2022, 6:30 PM
Alphare accepted this revision.Mar 3 2022, 5:14 AM
This revision is now accepted and ready to land.Mar 3 2022, 5:14 AM
indygreg updated this revision to Diff 32468.Mar 3 2022, 11:09 AM
indygreg added a commit: rHG10839394f39b: util: remove superfluous ispy3 test.Mar 3 2022, 11:55 AM
Closed by commit rHG10839394f39b: util: remove superfluous ispy3 test (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (2 lines)

Diff 32425

mercurial/util.py

# #
# The option of setting PYTHONWARNINGS in the test runner was investigated. # The option of setting PYTHONWARNINGS in the test runner was investigated.
# However, module name set through PYTHONWARNINGS was exactly matched, so # However, module name set through PYTHONWARNINGS was exactly matched, so
# we cannot set 'mercurial' and have it match eg: 'mercurial.scmutil'. This # we cannot set 'mercurial' and have it match eg: 'mercurial.scmutil'. This
# makes the whole PYTHONWARNINGS thing useless for our usecase. # makes the whole PYTHONWARNINGS thing useless for our usecase.
warnings.filterwarnings('default', '', DeprecationWarning, 'mercurial') warnings.filterwarnings('default', '', DeprecationWarning, 'mercurial')
warnings.filterwarnings('default', '', DeprecationWarning, 'hgext') warnings.filterwarnings('default', '', DeprecationWarning, 'hgext')
warnings.filterwarnings('default', '', DeprecationWarning, 'hgext3rd') warnings.filterwarnings('default', '', DeprecationWarning, 'hgext3rd')
if _dowarn and pycompat.ispy3: if _dowarn:
# silence warning emitted by passing user string to re.sub() # silence warning emitted by passing user string to re.sub()
warnings.filterwarnings( warnings.filterwarnings(
'ignore', 'bad escape', DeprecationWarning, 'mercurial' 'ignore', 'bad escape', DeprecationWarning, 'mercurial'
) )
warnings.filterwarnings( warnings.filterwarnings(
'ignore', 'invalid escape sequence', DeprecationWarning, 'mercurial' 'ignore', 'invalid escape sequence', DeprecationWarning, 'mercurial'
) )
# TODO: reinvent imp.is_frozen() # TODO: reinvent imp.is_frozen()