( )⚙ D12301 windows: remove conditional for Python 3

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12301

windows: remove conditional for Python 3
ClosedPublic

Authored by indygreg on Mar 2 2022, 6:30 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa98e32e5fca1: windows: remove conditional for Python 3

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 2 2022, 6:30 PM
Alphare accepted this revision.Mar 3 2022, 5:14 AM
This revision is now accepted and ready to land.Mar 3 2022, 5:14 AM
indygreg added a commit: rHGa98e32e5fca1: windows: remove conditional for Python 3.Mar 3 2022, 11:55 AM
Closed by commit rHGa98e32e5fca1: windows: remove conditional for Python 3 (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/windows.py (3 lines)

Diff 32426

mercurial/windows.py

def posixfile(name, mode=b'r', buffering=-1): def posixfile(name, mode=b'r', buffering=-1):
'''Open a file with even more POSIX-like semantics''' '''Open a file with even more POSIX-like semantics'''
try: try:
fp = osutil.posixfile(name, mode, buffering) # may raise WindowsError fp = osutil.posixfile(name, mode, buffering) # may raise WindowsError
# PyFile_FromFd() ignores the name, and seems to report fp.name as the # PyFile_FromFd() ignores the name, and seems to report fp.name as the
# underlying file descriptor. # underlying file descriptor.
if pycompat.ispy3:
fp = fdproxy(name, fp) fp = fdproxy(name, fp)
# The position when opening in append mode is implementation defined, so # The position when opening in append mode is implementation defined, so
# make it consistent with other platforms, which position at EOF. # make it consistent with other platforms, which position at EOF.
if b'a' in mode: if b'a' in mode:
fp.seek(0, os.SEEK_END) fp.seek(0, os.SEEK_END)
if b'+' in mode: if b'+' in mode:
return mixedfilemodewrapper(fp) return mixedfilemodewrapper(fp)