( )⚙ D12304 worker: remove Python 2 support code

This is an archive of the discontinued Mercurial Phabricator instance.

worker: remove Python 2 support code
ClosedPublic

Authored by indygreg on Mar 2 2022, 6:31 PM.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 2 2022, 6:31 PM
Alphare accepted this revision.Mar 3 2022, 5:21 AM
This revision is now accepted and ready to land.Mar 3 2022, 5:21 AM
indygreg updated this revision to Diff 32469.Mar 3 2022, 11:09 AM
This revision was automatically updated to reflect the committed changes.

It appears that this (or maybe another changeset in this series, I'm not sure), broke the pytype tests: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/457121

@indygreg could you follow-up?

It appears that this (or maybe another changeset in this series, I'm not sure), broke the pytype tests: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/457121
@indygreg could you follow-up?

It isn't surprising that pytype broke as a result of this series. I suspect what happened is the removal of a bunch of Python 2 code paths enabled pytype to make different (hopefully more accurate) inferences about types and this resulted in fallout. There's a good chance this will actually reveal legitimate typing bugs in the code base.

I'll try to take a look in a few hours.