This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1237

overlayworkingctx: add `_checkexist(path)`
ClosedPublic

Authored by phillco on Oct 26 2017, 12:48 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGbea46aed1e1b: overlayworkingctx: add `_checkexist(path)`
Summary

This is in preparation to switch this class to inheriting (and being based off
a) commitctx instead of a workingctx. filectx has no exists function,
so this is how we'll fall back in that case.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phillco updated this revision to Diff 4183.Dec 7 2017, 4:22 PM
durin42 accepted this revision.Dec 7 2017, 4:35 PM
This revision is now accepted and ready to land.Dec 7 2017, 4:35 PM
phillco updated this revision to Diff 4202.Dec 7 2017, 4:44 PM
Closed by commit rHGbea46aed1e1b: overlayworkingctx: add `_checkexist(path)` (authored by phillco). · Explain WhyDec 7 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (16 lines)

Diff 4225

mercurial/context.py

if self._cache[path]['exists']: if self._cache[path]['exists']:
return self._cache[path]['flags'] return self._cache[path]['flags']
else: else:
raise error.ProgrammingError("No such file or directory: %s" % raise error.ProgrammingError("No such file or directory: %s" %
self._path) self._path)
else: else:
return self._wrappedctx[path].flags() return self._wrappedctx[path].flags()
def _existsinparent(self, path):
try:
# ``commitctx` raises a ``ManifestLookupError`` if a path does not
# exist, unlike ``workingctx``, which returns a ``workingfilectx``
# with an ``exists()`` function.
self._wrappedctx[path]
return True
except error.ManifestLookupError:
return False
def write(self, path, data, flags=''): def write(self, path, data, flags=''):
if data is None: if data is None:
raise error.ProgrammingError("data must be non-None") raise error.ProgrammingError("data must be non-None")
self._markdirty(path, exists=True, data=data, date=util.makedate(), self._markdirty(path, exists=True, data=data, date=util.makedate(),
flags=flags) flags=flags)
def setflags(self, path, l, x): def setflags(self, path, l, x):
self._markdirty(path, exists=True, date=util.makedate(), self._markdirty(path, exists=True, date=util.makedate(),
if self.isdirty(path): if self.isdirty(path):
# If this path exists and is a symlink, "follow" it by calling # If this path exists and is a symlink, "follow" it by calling
# exists on the destination path. # exists on the destination path.
if (self._cache[path]['exists'] and if (self._cache[path]['exists'] and
'l' in self._cache[path]['flags']): 'l' in self._cache[path]['flags']):
return self.exists(self._cache[path]['data'].strip()) return self.exists(self._cache[path]['data'].strip())
else: else:
return self._cache[path]['exists'] return self._cache[path]['exists']
return self._wrappedctx[path].exists()
return self._existsinparent(path)
def lexists(self, path): def lexists(self, path):
"""lexists returns True if the path exists""" """lexists returns True if the path exists"""
if self.isdirty(path): if self.isdirty(path):
return self._cache[path]['exists'] return self._cache[path]['exists']
return self._wrappedctx[path].lexists()
return self._existsinparent(path)
def size(self, path): def size(self, path):
if self.isdirty(path): if self.isdirty(path):
if self._cache[path]['exists']: if self._cache[path]['exists']:
return len(self._cache[path]['data']) return len(self._cache[path]['data'])
else: else:
raise error.ProgrammingError("No such file or directory: %s" % raise error.ProgrammingError("No such file or directory: %s" %
self._path) self._path)