This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12406

histedit: remove an unnecessary default value of `b''` for commit message
ClosedPublic

Authored by martinvonz on Mar 25 2022, 1:38 AM.

Details

Reviewers
durin42
Alphare
Group Reviewers
hg-reviewers
Commits
rHG7bdf19f892c6: histedit: remove an unnecessary default value of `b''` for commit message
Summary

I don't think ctx.description() is ever anything falsy other than
b''. I think the comment added in 4c4232e51167 (histedit: extract
common summary code into method, 2016-05-27) is mistaken (I don't see
any code following that pattern before the function was added).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (5 lines)

Diff 32807

hgext/histedit.py

if not obsolete.isenabled(repo, obsolete.createmarkersopt): if not obsolete.isenabled(repo, obsolete.createmarkersopt):
backupfile = repair.backupbundle( backupfile = repair.backupbundle(
repo, [parentctxnode], [topmost], root, b'histedit' repo, [parentctxnode], [topmost], root, b'histedit'
) )
state.backupfile = backupfile state.backupfile = backupfile
def _getsummary(ctx): def _getsummary(ctx):
# a common pattern is to extract the summary but default to the empty return stringutil.firstline(ctx.description())
# string
summary = ctx.description() or b''
return stringutil.firstline(summary)
def bootstrapcontinue(ui, state, opts): def bootstrapcontinue(ui, state, opts):
repo = state.repo repo = state.repo
ms = mergestatemod.mergestate.read(repo) ms = mergestatemod.mergestate.read(repo)
mergeutil.checkunresolved(ms) mergeutil.checkunresolved(ms)