This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12486

rust-nodemap: remove unnecessary explicit lifetime
ClosedPublic

Authored by martinvonz on Apr 9 2022, 1:36 AM.

Download Raw Diff

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

Group Reviewers

Commits

rHGb97835b2e2d4: rust-nodemap: remove unnecessary explicit lifetime

Diff Detail

Repository

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

martinvonz created this revision.Apr 9 2022, 1:36 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptApr 9 2022, 1:36 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

martinvonz added a child revision: D12424: rust: upgrade zstd from 0.5.3 to 0.11.1.Apr 9 2022, 1:36 AM

Alphare accepted this revision.Apr 11 2022, 6:21 AM

This revision is now accepted and ready to land.Apr 11 2022, 6:21 AM

martinvonz edited parent revisions, added: D12547: rust-revlog: make unaware of `Repo`; removed: D12442: rust-revlog: add methods for getting parent revs and entries.Apr 14 2022, 12:13 PM

martinvonz edited parent revisions, added: D12562: rust-repo: extract a function for checking nodemap requirement; removed: D12547: rust-revlog: make unaware of `Repo`.Apr 15 2022, 12:52 PM

martinvonz added a child revision: D12548: changelog: avoid copying changeset data into `ChangesetRevisionData`.

martinvonz removed a child revision: D12424: rust: upgrade zstd from 0.5.3 to 0.11.1.

martinvonz edited parent revisions, added: D12565: rust-revlog: add tests for p1/p2 getters, as promised in D12442; removed: D12562: rust-repo: extract a function for checking nodemap requirement.Apr 16 2022, 1:47 AM

martinvonz added a commit: rHGb97835b2e2d4: rust-nodemap: remove unnecessary explicit lifetime.Apr 19 2022, 5:42 PM

Closed by commit rHGb97835b2e2d4: rust-nodemap: remove unnecessary explicit lifetime (authored by martinvonz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			rust/hg-core/src/revlog/nodemap.rs (2 lines)

Diff 32991

rust/hg-core/src/revlog/nodemap.rs

	for (i, visit_item) in self.visit(prefix).enumerate() {			for (i, visit_item) in self.visit(prefix).enumerate() {
	if let Some(opt) = visit_item.final_revision() {			if let Some(opt) = visit_item.final_revision() {
	return Ok((opt, i + 1));			return Ok((opt, i + 1));
	}			}
	}			}
	Err(NodeMapError::MultipleResults)			Err(NodeMapError::MultipleResults)
	}			}

	fn visit<'n>(&'n self, prefix: NodePrefix) -> NodeTreeVisitor<'n> {			fn visit(&self, prefix: NodePrefix) -> NodeTreeVisitor {
	NodeTreeVisitor {			NodeTreeVisitor {
	nt: self,			nt: self,
	prefix,			prefix,
	visit: self.len() - 1,			visit: self.len() - 1,
	nybble_idx: 0,			nybble_idx: 0,
	done: false,			done: false,
	}			}
	}			}