This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12568

git: un-byteify the `mode` argument for the builtin `open()`
ClosedPublic

Authored by mharbison72 on Apr 18 2022, 2:54 PM.

Details

Reviewers
durin42
Alphare
Group Reviewers
hg-reviewers
Commits
rHG020328be00cb: git: un-byteify the `mode` argument for the builtin `open()`
rHGd35c18ceaf0a: git: un-byteify the `mode` argument for the builtin `open()`
Summary

I guess this was assuming pycompat.open was imported, but it's not here or
elsewhere in the git extension.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mhgext/git/dirstate.py (2 lines)

Diff 33194

hgext/git/dirstate.py

pygit2 = gitutil.get_pygit2() pygit2 = gitutil.get_pygit2()
def readpatternfile(orig, filepath, warn, sourceinfo=False): def readpatternfile(orig, filepath, warn, sourceinfo=False):
if not (b'info/exclude' in filepath or filepath.endswith(b'.gitignore')): if not (b'info/exclude' in filepath or filepath.endswith(b'.gitignore')):
return orig(filepath, warn, sourceinfo=False) return orig(filepath, warn, sourceinfo=False)
result = [] result = []
warnings = [] warnings = []
with open(filepath, b'rb') as fp: with open(filepath, 'rb') as fp:
for l in fp: for l in fp:
l = l.strip() l = l.strip()
if not l or l.startswith(b'#'): if not l or l.startswith(b'#'):
continue continue
if l.startswith(b'!'): if l.startswith(b'!'):
warnings.append(b'unsupported ignore pattern %s' % l) warnings.append(b'unsupported ignore pattern %s' % l)
continue continue
if l.startswith(b'/'): if l.startswith(b'/'):