This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12618

auto-upgrade: add a test case where the repository is already locked
ClosedPublic

Authored by marmoute on Fri, May 6, 4:37 AM.

Download Raw Diff

Details

Reviewers

Alphare

Group Reviewers

hg-reviewers

Commits

rHG575f3dedb69a: auto-upgrade: add a test case where the repository is already locked

Summary

This show the current behavior when the repository to auto-upgrade is already
locked.

The current behavior is to abort, which is probably not great. Now that we have
a proper test, we can think about the behavior we wants in a later tests.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Fri, May 6, 4:37 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptFri, May 6, 4:37 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D12619: auto-upgrade: skip the operation if the repository cannot be locked.Fri, May 6, 4:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Tue, May 24, 9:39 AM

This revision is now accepted and ready to land.Tue, May 24, 9:39 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG575f3dedb69a: auto-upgrade: add a test case where the repository is already locked.Tue, May 24, 10:51 AM

Closed by commit rHG575f3dedb69a: auto-upgrade: add a test case where the repository is already locked (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-upgrade-repo.t (15 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	33370		Fri, May 6, 4:37 AM	★	★
Diff 2	33416		Thu, May 19, 6:36 AM	★	★
Diff 3	33431		Tue, May 24, 10:34 AM	★	★
Diff 4	33441	rHG575f3dedb69a8803e4f491637ebeccc75373b89f	Apr 4 2022, 10:45 PM	★	★

Status	Author	Revision
Closed	marmoute	D12619 auto-upgrade: skip the operation if the repository cannot be locked
Closed	marmoute	D12618 auto-upgrade: add a test case where the repository is already locked
Closed	marmoute	D12617 wait-on-file: properly wait on any files and symlink
Closed	marmoute	D12616 debuglock: make the command more useful in non-interactive mode
Closed	marmoute	D12615 auto-upgrade: add a test case with no permission to lock the repository
Closed	marmoute	D12614 auto-upgrade: introduce a way to auto-upgrade to/from dirstate-v2
Closed	marmoute	D12613 auto-upgrade: introduce a way to auto-upgrade to/from tracked-hint
Closed	marmoute	D12612 upgrade: split some logic from UpgradeOperation
Closed	marmoute	D12611 auto-upgrade: introduce a way to auto-upgrade to/from share-safe
Closed	marmoute	D12610 rust: make requirements public

Diff 33441

tests/test-upgrade-repo.t

	> --config format.use-dirstate-v2=no			> --config format.use-dirstate-v2=no
	abort: could not lock working directory of auto-upgrade: Permission denied			abort: could not lock working directory of auto-upgrade: Permission denied
	[20]			[20]
	$ hg debugformat -R auto-upgrade \| grep dirstate-v2			$ hg debugformat -R auto-upgrade \| grep dirstate-v2
	dirstate-v2: yes			dirstate-v2: yes

	$ chmod -R u+w auto-upgrade			$ chmod -R u+w auto-upgrade

				Attempting Auto-upgrade on a locked repository
				----------------------------------------------

				$ hg -R auto-upgrade debuglock --set-lock --quiet &
				$ echo $! >> $DAEMON_PIDS
				$ $RUNTESTDIR/testlib/wait-on-file 10 auto-upgrade/.hg/store/lock
				$ hg status -R auto-upgrade \
				> --config format.use-dirstate-v2.automatic-upgrade-of-mismatching-repositories=yes \
				> --config format.use-dirstate-v2=no
				abort: repository auto-upgrade: timed out waiting for lock held by 'brunhoff/effffffc:1215708'
				[20]
				$ hg debugformat -R auto-upgrade \| grep dirstate-v2
				dirstate-v2: yes

				$ killdaemons.py