( )⚙ D1280 basepackstore: log the number of packs on initialization

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1280

basepackstore: log the number of packs on initialization
ClosedPublic

Authored by phillco on Nov 1 2017, 2:13 PM.
Tags
None
Subscribers
None

Details

Reviewers
durham
quark
Group Reviewers
Restricted Project
Commits
rFBHGX44857b178746: basepackstore: log the number of packs on initialization
Summary

This way we could get a handle on how many packs users are contending with.

Note that this location is unsatisfactory because we have so little metadata
available -- it'd be nice to denote type of store (data, history), type of
content (data, trees), and location of store (local, cache). Perhaps callers
could pass these keys to the constructor.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

phillco created this revision.Nov 1 2017, 2:13 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2017, 2:13 PM
quark accepted this revision.Nov 1 2017, 2:18 PM
This revision is now accepted and ready to land.Nov 1 2017, 2:18 PM
durham accepted this revision.Nov 1 2017, 2:18 PM
phillco closed this revision.Nov 2 2017, 1:08 PM

Revision Contents
Changeset List

PathPackages
Mremotefilelog/basepack.py (3 lines)

Diff 3191

remotefilelog/basepack.py

# #
# If this is an ENOENT error then don't even bother logging. # If this is an ENOENT error then don't even bother logging.
# Someone could have removed the file since we retrieved the # Someone could have removed the file since we retrieved the
# list of paths. # list of paths.
if getattr(ex, 'errno', None) != errno.ENOENT: if getattr(ex, 'errno', None) != errno.ENOENT:
ui.warn(_('unable to load pack %s: %s\n') % (filepath, ex)) ui.warn(_('unable to load pack %s: %s\n') % (filepath, ex))
continue continue
self.packs.append(pack) self.packs.append(pack)
numpacks = len(self.packs)
ui.log("packsizes", "packstore %s has %d packs\n" % (path, numpacks),
numpacks=numpacks)
def _getavailablepackfiles(self): def _getavailablepackfiles(self):
suffixlen = len(self.INDEXSUFFIX) suffixlen = len(self.INDEXSUFFIX)
files = [] files = []
filenames = set() filenames = set()
try: try:
for filename, size, stat in osutil.listdir(self.path, stat=True): for filename, size, stat in osutil.listdir(self.path, stat=True):