This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1287

repoview: add two new filternames to be used for accessing hidden commits
AbandonedPublic

Authored by pulkit on Nov 2 2017, 2:09 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

This patch adds two new filternames 'visible-allowhidden' and
'visible-warnhidden' which will be used to access hidden commits.

'visible-allowhidden' will allow access of hidden commits without any warning.
This will be for read only commands.
'visible-warnhidden' will allow acces of hidden commits but will warn for that.
This will be for recoverable write commands.

For unrecoverable write commands, we don't need to have anything new as that's
the current behaviour.

The idea to add new filternames is taken from directaccess extension from
fb-hgext.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (4 lines)
Mmercurial/repoview.py (10 lines)

Diff 4095

mercurial/branchmap.py

# Nearest subset of filter X is a filter Y so that: # Nearest subset of filter X is a filter Y so that:
# * Y is included in X, # * Y is included in X,
# * X - Y is as small as possible. # * X - Y is as small as possible.
# This create and ordering used for branchmap purpose. # This create and ordering used for branchmap purpose.
# the ordering may be partial # the ordering may be partial
subsettable = {None: 'visible', subsettable = {None: 'visible',
'visible': 'served', 'visible': 'served',
'served': 'immutable', 'served': 'immutable',
'immutable': 'base'} 'immutable': 'base',
'visible-warnhidden': 'visible',
'visible-allowhidden': 'visible'}
def updatecache(repo): def updatecache(repo):
cl = repo.changelog cl = repo.changelog
filtername = repo.filtername filtername = repo.filtername
partial = repo._branchcaches.get(filtername) partial = repo._branchcaches.get(filtername)
revs = [] revs = []
if partial is None or not partial.validfor(repo): if partial is None or not partial.validfor(repo):

mercurial/repoview.py

def computehidden(repo): def computehidden(repo):
"""compute the set of hidden revision to filter """compute the set of hidden revision to filter
During most operation hidden should be filtered.""" During most operation hidden should be filtered."""
assert not repo.changelog.filteredrevs assert not repo.changelog.filteredrevs
return _computeperfiltername(repo, 'visible') return _computeperfiltername(repo, 'visible')
def computewarnhidden(repo):
assert not repo.changelog.filteredrevs
return _computeperfiltername(repo, 'visible-warnhidden')
def computeallowhidden(repo):
assert not repo.changelog.filteredrevs
return _computeperfiltername(repo, 'visible-allowhidden')
def computeunserved(repo): def computeunserved(repo):
"""compute the set of revision that should be filtered when used a server """compute the set of revision that should be filtered when used a server
Secret and hidden changeset should not pretend to be here.""" Secret and hidden changeset should not pretend to be here."""
assert not repo.changelog.filteredrevs assert not repo.changelog.filteredrevs
# fast path in simple case to avoid impact of non optimised code # fast path in simple case to avoid impact of non optimised code
hiddens = filterrevs(repo, 'visible') hiddens = filterrevs(repo, 'visible')
if phases.hassecret(repo): if phases.hassecret(repo):
# function to compute filtered set # function to compute filtered set
# #
# When adding a new filter you MUST update the table at: # When adding a new filter you MUST update the table at:
# mercurial.branchmap.subsettable # mercurial.branchmap.subsettable
# Otherwise your filter will have to recompute all its branches cache # Otherwise your filter will have to recompute all its branches cache
# from scratch (very slow). # from scratch (very slow).
filtertable = {'visible': computehidden, filtertable = {'visible': computehidden,
'visible-warnhidden': computewarnhidden,
'visible-allowhidden': computeallowhidden,
'served': computeunserved, 'served': computeunserved,
'immutable': computemutable, 'immutable': computemutable,
'base': computeimpactable} 'base': computeimpactable}
def filterrevs(repo, filtername): def filterrevs(repo, filtername):
"""returns set of filtered revision for this filter name""" """returns set of filtered revision for this filter name"""
if filtername not in repo.filteredrevcache: if filtername not in repo.filteredrevcache:
func = filtertable[filtername] func = filtertable[filtername]