This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1492

repoview: take out the logic of computehidden to a new function
AbandonedPublic

Authored by pulkit on Nov 22 2017, 8:24 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

We are going to use that logic in compute functions for the new filternames
which will be introduced in the next patch. So lets make a utility function
which takes filtername and can be used by related compute functions.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/repoview.py (15 lines)

Diff 4093

mercurial/repoview.py

""" """
stack = list(revs) stack = list(revs)
while stack: while stack:
for p in pfunc(stack.pop()): for p in pfunc(stack.pop()):
if p != nullrev and p in hidden: if p != nullrev and p in hidden:
hidden.remove(p) hidden.remove(p)
stack.append(p) stack.append(p)
def computehidden(repo): def _computeperfiltername(repo, filtername):
"""compute the set of hidden revision to filter """computes the set of revisions to filter for visible* filters"""
During most operation hidden should be filtered."""
assert not repo.changelog.filteredrevs
hidden = hideablerevs(repo) hidden = hideablerevs(repo)
if hidden: if hidden:
hidden = set(hidden - pinnedrevs(repo)) hidden = set(hidden - pinnedrevs(repo))
pfunc = repo.changelog.parentrevs pfunc = repo.changelog.parentrevs
mutablephases = (phases.draft, phases.secret) mutablephases = (phases.draft, phases.secret)
mutable = repo._phasecache.getrevset(repo, mutablephases) mutable = repo._phasecache.getrevset(repo, mutablephases)
visible = mutable - hidden visible = mutable - hidden
_revealancestors(pfunc, hidden, visible) _revealancestors(pfunc, hidden, visible)
return frozenset(hidden) return frozenset(hidden)
def computehidden(repo):
"""compute the set of hidden revision to filter
During most operation hidden should be filtered."""
assert not repo.changelog.filteredrevs
return _computeperfiltername(repo, 'visible')
def computeunserved(repo): def computeunserved(repo):
"""compute the set of revision that should be filtered when used a server """compute the set of revision that should be filtered when used a server
Secret and hidden changeset should not pretend to be here.""" Secret and hidden changeset should not pretend to be here."""
assert not repo.changelog.filteredrevs assert not repo.changelog.filteredrevs
# fast path in simple case to avoid impact of non optimised code # fast path in simple case to avoid impact of non optimised code
hiddens = filterrevs(repo, 'visible') hiddens = filterrevs(repo, 'visible')
if phases.hassecret(repo): if phases.hassecret(repo):