Page MenuHomePhabricator

repoview: store visibility exceptions for the filter in filtertable
AbandonedPublic

Authored by pulkit on Dec 19 2017, 7:09 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Summary

Earlier, filtertable contains the filtername and the corresponding function to
calculate filtered set for that filter. This patch make filtertable also store
the visibility exceptions for that filter. filtertable was a dictionary with
filtername as the key and function as the value, after this patch, the value is
a tuple of form (fn, visibilityexceptions).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Dec 19 2017, 7:09 AM
yuja requested changes to this revision.Dec 19 2017, 9:05 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/repoview.py
145

So this is global across repositories and permanently cached.

Can't we store the "exceptions" in repoview? I think their lifetime
should be the same.

This revision now requires changes to proceed.Dec 19 2017, 9:05 AM
pulkit abandoned this revision.Jan 10 2018, 3:51 AM