This is an archive of the discontinued Mercurial Phabricator instance.

Differential D13

contrib: widen the "don't use `python`" net a little
ClosedPublic

Authored by durin42 on Jul 5 2017, 12:35 PM.
Tags
None
Subscribers
dsp

Details

Reviewers
krbullock
Commits
rHG98f6c25aaf61: contrib: widen the "don't use `python`" net a little
Summary

I'm still cleaning this up, but it's easier to do in bite-size chunks
like this than all at once. The negative lookahead avoids one false
positive category from some output related to finding Subversion
bindings.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dsp accepted this revision.Jul 6 2017, 11:20 AM
dsp added a subscriber: dsp.

I hope it's okay that I am accepting this. Looks good to me. I think it might be nice to add the example of 'python bindings' in the description.

goodcatch

This revision is now accepted and ready to land.Jul 6 2017, 11:20 AM
dsp changed the visibility from "All Users" to "Public (No Login Required)".Jul 6 2017, 12:02 PM
quark removed a reviewer: dsp.Jul 6 2017, 12:49 PM
This revision now requires review to proceed.Jul 6 2017, 12:49 PM
krbullock accepted this revision.Jul 6 2017, 3:43 PM
This revision is now accepted and ready to land.Jul 6 2017, 3:43 PM
Closed by commit rHG98f6c25aaf61: contrib: widen the "don't use `python`" net a little (authored by durin42). · Explain WhyJul 7 2017, 10:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (2 lines)

Diff 29

contrib/check-code.py

(r'if\s*!', "don't use '!' to negate exit status"), (r'if\s*!', "don't use '!' to negate exit status"),
(r'/dev/u?random', "don't use entropy, use /dev/zero"), (r'/dev/u?random', "don't use entropy, use /dev/zero"),
(r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"), (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
(r'^( *)\t', "don't use tabs to indent"), (r'^( *)\t', "don't use tabs to indent"),
(r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)', (r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',
"put a backslash-escaped newline after sed 'i' command"), "put a backslash-escaped newline after sed 'i' command"),
(r'^diff *-\w*[uU].*$\n(^ \$ |^$)', "prefix diff -u/-U with cmp"), (r'^diff *-\w*[uU].*$\n(^ \$ |^$)', "prefix diff -u/-U with cmp"),
(r'^\s+(if)? diff *-\w*[uU]', "prefix diff -u/-U with cmp"), (r'^\s+(if)? diff *-\w*[uU]', "prefix diff -u/-U with cmp"),
(r'python\s.+\.py', "don't use 'python', use '$PYTHON'"), (r'\spython\s(?!bindings)', "don't use 'python', use '$PYTHON'"),
(r'seq ', "don't use 'seq', use $TESTDIR/seq.py"), (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
(r'\butil\.Abort\b', "directly use error.Abort"), (r'\butil\.Abort\b', "directly use error.Abort"),
(r'\|&', "don't use |&, use 2>&1"), (r'\|&', "don't use |&, use 2>&1"),
(r'\w = +\w', "only one space after = allowed"), (r'\w = +\w', "only one space after = allowed"),
(r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
(r'grep.* -[ABC] ', "don't use grep's context flags"), (r'grep.* -[ABC] ', "don't use grep's context flags"),