_droppath() already checks "dirs" in self._map.__dict__ before accessing
self._map.dirs. This updates _addpath() to be equally cautious.
Details
Details
- Reviewers
mbthomas - Group Reviewers
hg-reviewers
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
mercurial/dirstate.py | ||
---|---|---|
405 | I don't think it's safe to do this. We're looking for clashes between files and directories, so we do need to look in self.dirs, even if that means generating it because we're accessing it for the first time. |
Comment Actions
Do we need this anymore or can this be abandoned? (trying to close some not-required-any-more differentials)
I don't think it's safe to do this. We're looking for clashes between files and directories, so we do need to look in self.dirs, even if that means generating it because we're accessing it for the first time.