This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1338

dirstate: clear map cached properties when clearing the map
ClosedPublic

Authored by mbthomas on Nov 8 2017, 12:30 PM.

Details

Reviewers
indygreg
durin42
Group Reviewers
hg-reviewers
Commits
rHGecede5263adb: dirstate: clear map cached properties when clearing the map
Summary

dirstatemap.clear should remove all record of the files in the map. This
includes removing caches of values derived from these.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mbthomas created this revision.Nov 8 2017, 12:30 PM
indygreg accepted this revision.Nov 10 2017, 12:20 AM
This revision is now accepted and ready to land.Nov 10 2017, 12:20 AM
durin42 accepted this revision.Nov 10 2017, 5:12 PM
Closed by commit rHGecede5263adb: dirstate: clear map cached properties when clearing the map (authored by mbthomas). · Explain WhyNov 10 2017, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (5 lines)

Diff 3338

mercurial/dirstate.py

self.copymap = {} self.copymap = {}
self._map self._map
return self.copymap return self.copymap
def clear(self): def clear(self):
self._map.clear() self._map.clear()
self.copymap.clear() self.copymap.clear()
self.setparents(nullid, nullid) self.setparents(nullid, nullid)
util.clearcachedproperty(self, "dirs")
util.clearcachedproperty(self, "filefoldmap")
util.clearcachedproperty(self, "dirfoldmap")
util.clearcachedproperty(self, "nonnormalset")
util.clearcachedproperty(self, "otherparentset")
def iteritems(self): def iteritems(self):
return self._map.iteritems() return self._map.iteritems()
def __len__(self): def __len__(self):
return len(self._map) return len(self._map)
def __iter__(self): def __iter__(self):