This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1373

bundlerepo: use suffix variable
ClosedPublic

Authored by indygreg on Nov 11 2017, 9:51 PM.

Details

Reviewers
dlax
durin42
Group Reviewers
hg-reviewers
Commits
rHG80e9b85d96e5: bundlerepo: use suffix variable
Summary

It looks like the refactor in 702a26fec3e2 attempted to establish
this method argument but failed to use it. My editor caught it.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Nov 11 2017, 9:51 PM
dlax accepted this revision.Nov 13 2017, 2:52 AM
durin42 accepted this revision.Nov 13 2017, 5:19 PM
This revision is now accepted and ready to land.Nov 13 2017, 5:19 PM
Closed by commit rHG80e9b85d96e5: bundlerepo: use suffix variable (authored by indygreg). · Explain WhyNov 13 2017, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundlerepo.py (2 lines)

Diff 3428

mercurial/bundlerepo.py

".cg%sun" % version) ".cg%sun" % version)
self.bundle = changegroup.getunbundler(version, cgstream, 'UN') self.bundle = changegroup.getunbundler(version, cgstream, 'UN')
def _writetempbundle(self, readfn, suffix, header=''): def _writetempbundle(self, readfn, suffix, header=''):
"""Write a temporary file to disk """Write a temporary file to disk
""" """
fdtemp, temp = self.vfs.mkstemp(prefix="hg-bundle-", fdtemp, temp = self.vfs.mkstemp(prefix="hg-bundle-",
suffix=".hg10un") suffix=suffix)
self.tempfile = temp self.tempfile = temp
with os.fdopen(fdtemp, pycompat.sysstr('wb')) as fptemp: with os.fdopen(fdtemp, pycompat.sysstr('wb')) as fptemp:
fptemp.write(header) fptemp.write(header)
while True: while True:
chunk = readfn(2**18) chunk = readfn(2**18)
if not chunk: if not chunk:
break break