This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1435

tests: fix too many files error in datapack store
ClosedPublic

Authored by durham on Nov 16 2017, 12:23 PM.
Tags
None
Subscribers
None

Details

Reviewers
phillco
Group Reviewers
Restricted Project
Commits
rFBHGX80dab2643ade: tests: fix too many files error in datapack store
Summary

If the os limited a given process to a <200 files open, this test would fail.
Let's change the cache size to be smaller to avoid this.

Also, it turns out the cache size and number of packs created doesn't actually
seem to affect this test. I changed the numbers in a few ways and the test never
failed.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durham created this revision.Nov 16 2017, 12:23 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 12:23 PM
phillco accepted this revision.Nov 16 2017, 12:46 PM
This revision is now accepted and ready to land.Nov 16 2017, 12:46 PM
Closed by commit rFBHGX80dab2643ade: tests: fix too many files error in datapack store (authored by durham). · Explain WhyNov 16 2017, 2:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/remotefilelog-datapack.py (39 lines)

Diff 3577

tests/remotefilelog-datapack.py

#!/usr/bin/env python #!/usr/bin/env python
import hashlib import hashlib
import os import os
import random import random
import resource
import shutil import shutil
import stat import stat
import struct import struct
import sys import sys
import tempfile import tempfile
import time import time
import unittest import unittest
def testPacksCache(self): def testPacksCache(self):
"""Test that we remember the most recent packs while fetching the delta """Test that we remember the most recent packs while fetching the delta
chain.""" chain."""
packdir = self.makeTempDir() packdir = self.makeTempDir()
deltachains = [] deltachains = []
# Ensures that we are not keeping everything in the cache. numpacks = 10
numpacks = datapackstore.DEFAULTCACHESIZE * 2
revisionsperpack = 100 revisionsperpack = 100
for i in range(numpacks): for i in range(numpacks):
chain = [] chain = []
revision = (str(i), self.getFakeHash(), nullid, "content") revision = (str(i), self.getFakeHash(), nullid, "content")
for _ in range(revisionsperpack): for _ in range(revisionsperpack):
chain.append(revision) chain.append(revision)
revision = ( revision = (
str(i), str(i),
self.getFakeHash(), self.getFakeHash(),
revision[1], revision[1],
self.getFakeHash() self.getFakeHash()
) )
self.createPack(chain, packdir) self.createPack(chain, packdir)
deltachains.append(chain) deltachains.append(chain)
try: class testdatapackstore(datapackstore):
store = datapackstore(mercurial.ui.ui(), packdir) # Ensures that we are not keeping everything in the cache.
DEFAULTCACHESIZE = numpacks / 2
store = testdatapackstore(mercurial.ui.ui(), packdir)
random.shuffle(deltachains) random.shuffle(deltachains)
for randomchain in deltachains: for randomchain in deltachains:
revision = random.choice(randomchain) revision = random.choice(randomchain)
chain = store.getdeltachain(revision[0], revision[1]) chain = store.getdeltachain(revision[0], revision[1])
mostrecentpack = next(iter(store.packs), None) mostrecentpack = next(iter(store.packs), None)
self.assertEquals( self.assertEquals(
mostrecentpack.getdeltachain(revision[0], revision[1]), mostrecentpack.getdeltachain(revision[0], revision[1]),
chain chain
) )
self.assertEquals(randomchain.index(revision) + 1, len(chain)) self.assertEquals(randomchain.index(revision) + 1, len(chain))
except Exception as ex:
print('Exception: %r' % ex)
# Print out RLIMIT_NOFILE
print('RLIMIT_NOFILE: %r'
% (resource.getrlimit(resource.RLIMIT_NOFILE),))
# Print debug information about what files are opened by the
# current process.
os.system('lsof -p %s' % os.getpid())
# perf test off by default since it's slow # perf test off by default since it's slow
def _testIndexPerf(self): def _testIndexPerf(self):
random.seed(0) random.seed(0)
print "Multi-get perf test" print "Multi-get perf test"
packsizes = [ packsizes = [
100, 100,
10000, 10000,