This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1442

test-remotefilelog-datapack: use more packs for cdatapack code path
ClosedPublic

Authored by quark on Nov 16 2017, 7:27 PM.
Tags
None
Subscribers
None

Details

Reviewers
singhsrb
durham
Group Reviewers
Restricted Project
Commits
rFBHGX27f1a89cd4b5: test-remotefilelog-datapack: use more packs for cdatapack code path
Summary

The number 200 was used before D1435. It caused trouble on systems with low
ulimit -n and with the Python datapack code path because Python's mmap
implementation keeps an internal fd for every mmap object and there is no
way to close those fds via pure Python API. But there is no such limit for
cdatapack after D1185. So let's change cdatapack test to use 200 packs.

Test Plan

ulimit -n 50 and ./scripts/unit.py

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Nov 16 2017, 7:27 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 7:27 PM
quark edited the summary of this revision. (Show Details)Nov 16 2017, 7:31 PM
quark edited the test plan for this revision. (Show Details)
singhsrb accepted this revision.Nov 16 2017, 7:48 PM
This revision is now accepted and ready to land.Nov 16 2017, 7:48 PM
durham accepted this revision.Nov 16 2017, 8:39 PM
Closed by commit rFBHGX27f1a89cd4b5: test-remotefilelog-datapack: use more packs for cdatapack code path (authored by quark). · Explain WhyNov 20 2017, 9:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3640

tests/test-remotefilelog-datapack.py

def testPacksCache(self): def testPacksCache(self):
"""Test that we remember the most recent packs while fetching the delta """Test that we remember the most recent packs while fetching the delta
chain.""" chain."""
packdir = self.makeTempDir() packdir = self.makeTempDir()
deltachains = [] deltachains = []
if self.iscdatapack:
numpacks = 200
else:
numpacks = 10 numpacks = 10
revisionsperpack = 100 revisionsperpack = 100
for i in range(numpacks): for i in range(numpacks):
chain = [] chain = []
revision = (str(i), self.getFakeHash(), nullid, "content") revision = (str(i), self.getFakeHash(), nullid, "content")
for _ in range(revisionsperpack): for _ in range(revisionsperpack):
chain.append(revision) chain.append(revision)