This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1441

test-remotefilelog-datapack: exercise cdatapack code path
ClosedPublic

Authored by quark on Nov 16 2017, 7:27 PM.
Tags
None
Subscribers
durham, singhsrb

Details

Reviewers
singhsrb
Group Reviewers
Restricted Project
Commits
rFBHGX0955a7f1f60d: test-remotefilelog-datapack: exercise cdatapack code path
Summary

In fastdatapacktests.testPacksCache, the C datapack code path should be
used.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Nov 16 2017, 7:27 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 7:27 PM
singhsrb accepted this revision.Nov 16 2017, 7:41 PM
singhsrb added a subscriber: singhsrb.

All good! Just a minor comment which you can ignore :).

tests/test-remotefilelog-datapack.py
39

nit: paramsavailable seems weird especially with self.iscdatapack = not paramsavailable. Maybe rename this to something more meaningful. I would even prefer it the other way round i.e.

def __init__(self, datapackreader,  iscdatapack):
        self.datapackreader = datapackreader
        self.iscdatapack = iscdatapack
        self.paramsavailable = not iscdatapack
This revision is now accepted and ready to land.Nov 16 2017, 7:41 PM
durham added a subscriber: durham.Nov 16 2017, 8:38 PM
durham added inline comments.
tests/test-remotefilelog-datapack.py
39

+1

Closed by commit rFBHGX0955a7f1f60d: test-remotefilelog-datapack: exercise cdatapack code path (authored by quark). · Explain WhyNov 20 2017, 9:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3639

tests/test-remotefilelog-datapack.py

LARGEFANOUTPREFIX, LARGEFANOUTPREFIX,
) )
from remotefilelog import constants from remotefilelog import constants
from mercurial.node import nullid from mercurial.node import nullid
import mercurial.ui import mercurial.ui
class datapacktestsbase(object): class datapacktestsbase(object):
def __init__(self, datapackreader, paramsavailable): def __init__(self, datapackreader, paramsavailable, iscdatapack):
singhsrbUnsubmitted
Not Done

nit: paramsavailable seems weird especially with self.iscdatapack = not paramsavailable. Maybe rename this to something more meaningful. I would even prefer it the other way round i.e.

def __init__(self, datapackreader,  iscdatapack):
        self.datapackreader = datapackreader
        self.iscdatapack = iscdatapack
        self.paramsavailable = not iscdatapack
singhsrb: nit: `paramsavailable` seems weird especially with `self.iscdatapack = not paramsavailable`.
durhamUnsubmitted
Not Done

+1

durham: +1
self.datapackreader = datapackreader self.datapackreader = datapackreader
self.iscdatapack = iscdatapack
self.paramsavailable = paramsavailable self.paramsavailable = paramsavailable
def setUp(self): def setUp(self):
self.tempdirs = [] self.tempdirs = []
def tearDown(self): def tearDown(self):
for d in self.tempdirs: for d in self.tempdirs:
shutil.rmtree(d) shutil.rmtree(d)
self.createPack(chain, packdir) self.createPack(chain, packdir)
deltachains.append(chain) deltachains.append(chain)
class testdatapackstore(datapackstore): class testdatapackstore(datapackstore):
# Ensures that we are not keeping everything in the cache. # Ensures that we are not keeping everything in the cache.
DEFAULTCACHESIZE = numpacks / 2 DEFAULTCACHESIZE = numpacks / 2
store = testdatapackstore(mercurial.ui.ui(), packdir) store = testdatapackstore(mercurial.ui.ui(), packdir, self.iscdatapack)
random.shuffle(deltachains) random.shuffle(deltachains)
for randomchain in deltachains: for randomchain in deltachains:
revision = random.choice(randomchain) revision = random.choice(randomchain)
chain = store.getdeltachain(revision[0], revision[1]) chain = store.getdeltachain(revision[0], revision[1])
mostrecentpack = next(iter(store.packs), None) mostrecentpack = next(iter(store.packs), None)
self.assertEquals( self.assertEquals(
gc.enable() gc.enable()
# The perf test is meant to produce output, so we always fail the test # The perf test is meant to produce output, so we always fail the test
# so the user sees the output. # so the user sees the output.
raise RuntimeError("perf test always fails") raise RuntimeError("perf test always fails")
class datapacktests(datapacktestsbase, unittest.TestCase): class datapacktests(datapacktestsbase, unittest.TestCase):
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):
datapacktestsbase.__init__(self, datapack, True) datapacktestsbase.__init__(self, datapack, True, False)
unittest.TestCase.__init__(self, *args, **kwargs) unittest.TestCase.__init__(self, *args, **kwargs)
class fastdatapacktests(datapacktestsbase, unittest.TestCase): class fastdatapacktests(datapacktestsbase, unittest.TestCase):
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):
datapacktestsbase.__init__(self, fastdatapack, False) datapacktestsbase.__init__(self, fastdatapack, False, True)
unittest.TestCase.__init__(self, *args, **kwargs) unittest.TestCase.__init__(self, *args, **kwargs)
# TODO: # TODO:
# datapack store: # datapack store:
# - getmissing # - getmissing
# - GC two packs into one # - GC two packs into one
if __name__ == '__main__': if __name__ == '__main__':
silenttestrunner.main(__name__) silenttestrunner.main(__name__)