This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1462

tests: add test for rebase template showing wrong behavior
ClosedPublic

Authored by pulkit on Nov 20 2017, 2:03 PM.

Details

Reviewers
durin42
yuja
Group Reviewers
hg-reviewers
Commits
rHGc157bb0120a9: tests: add test for rebase template showing wrong behavior
Summary

The output for template "{nodechanges % ':{value}'}" does not contain the
output for value.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Nov 20 2017, 2:03 PM
durin42 requested changes to this revision.Nov 20 2017, 6:27 PM
durin42 added a subscriber: durin42.
durin42 added inline comments.
tests/test-rebase-templates.t
56

Can you comment what the correct behavior here should be? Yuya had a clever trick of (!true) or something to put the expected output inline with the actual output...

This revision now requires changes to proceed.Nov 20 2017, 6:27 PM
pulkit updated this revision to Diff 3704.Nov 20 2017, 8:04 PM
pulkit updated this revision to Diff 3724.Nov 21 2017, 11:54 AM
yuja accepted this revision.Nov 22 2017, 8:18 AM
Closed by commit rHGc157bb0120a9: tests: add test for rebase template showing wrong behavior (authored by pulkit). · Explain WhyNov 22 2017, 8:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-rebase-templates.t (14 lines)

Diff 3766

tests/test-rebase-templates.t

o 4:849767420fd5 Added c o 4:849767420fd5 Added c
| |
| o 1:29becc82797a Added b | o 1:29becc82797a Added b
|/ |/
o 0:18d04c59bb5d Added a o 0:18d04c59bb5d Added a
$ hg rebase -s 1 -d 5 -q -T "{nodechanges|json}" $ hg rebase -s 1 -d 5 -q -T "{nodechanges|json}"
{"29becc82797a4bc11ec8880b58eaecd2ab3e7760": ["d9d6773efc831c274eace04bc13e8e6412517139"]} (no-eol) {"29becc82797a4bc11ec8880b58eaecd2ab3e7760": ["d9d6773efc831c274eace04bc13e8e6412517139"]} (no-eol)
$ hg log -G -T "{rev}:{node|short} {desc}"
o 6:d9d6773efc83 Added b
|
@ 5:df21b32134ba Added d
|
o 4:849767420fd5 Added c
|
o 0:18d04c59bb5d Added a
$ hg rebase -s 6 -d 4 -q -T "{nodechanges % '{oldnode}:{newnodes % ' {node} '}'}"
durin42Unsubmitted
Not Done

Can you comment what the correct behavior here should be? Yuya had a clever trick of (!true) or something to put the expected output inline with the actual output...

durin42: Can you comment what the correct behavior here should be? Yuya had a clever trick of (!true) or…
d9d6773efc831c274eace04bc13e8e6412517139: f48cd65c6dc3d2acb55da54402a5b029546e546f (no-eol) (false !)
d9d6773efc831c274eace04bc13e8e6412517139 (no-eol)