This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1502

rewriteutil: add utility function to check if we can create new unstable cset
ClosedPublic

Authored by pulkit on Nov 23 2017, 5:39 PM.

Details

Reviewers
dlax
durin42
Group Reviewers
hg-reviewers
Commits
rHG27d5c2d2db2b: rewriteutil: add utility function to check if we can create new unstable cset
Summary

This patch adds a new file which will contain utility functions related to
rewritting changesets. It also adds a utility function to check if the
rewritting operation creates new unstable changesets and are we allowed to
create them.

This rewriteutil.py introduced in this patch and the utility functions added in
the upcoming patches exists in the evolve extension are being ported from there.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Nov 23 2017, 5:39 PM
dlax added a subscriber: dlax.Nov 24 2017, 4:35 AM

This rewriteutil.py introduced in this patch and the utility functions added in the upcoming patches exists in the evolve extension are being ported from there.

Is it worth porting this alone if nothing in core makes use of this module?
Or is there a larger plan?

pulkit updated this revision to Diff 3899.Nov 27 2017, 7:37 PM
pulkit added a comment.Nov 27 2017, 7:40 PM
In D1502#25341, @dlax wrote:

This rewriteutil.py introduced in this patch and the utility functions added in the upcoming patches exists in the evolve extension are being ported from there.

Is it worth porting this alone if nothing in core makes use of this module?
Or is there a larger plan?

I have updated the series with couple of usages. More functions will be introduced which will be used by both core and extensions.

dlax requested changes to this revision.Nov 28 2017, 4:18 AM
dlax added inline comments.
mercurial/rewriteutil.py
21

typo: allounstable

This revision now requires changes to proceed.Nov 28 2017, 4:18 AM
pulkit updated this revision to Diff 3911.Nov 28 2017, 2:14 PM
dlax accepted this revision.Nov 28 2017, 2:25 PM
durin42 accepted this revision.Dec 5 2017, 5:52 PM
This revision is now accepted and ready to land.Dec 5 2017, 5:52 PM
Closed by commit rHG27d5c2d2db2b: rewriteutil: add utility function to check if we can create new unstable cset (authored by pulkit). · Explain WhyDec 5 2017, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMmercurial/rewriteutil.py (25 lines)

Diff 4144

mercurial/rewriteutil.py

  • This file was added.
# rewriteutil.py - utility functions for rewriting changesets
#
# Copyright 2017 Octobus <contact@octobus.net>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
from . import (
obsolete,
revset,
)
def disallowednewunstable(repo, revs):
"""Checks whether editing the revs will create new unstable changesets and
are we allowed to create them.
To allow new unstable changesets, set the config:
`experimental.evolution.allowunstable=True`
"""
dlaxUnsubmitted
Not Done

typo: allounstable

dlax: typo: allounstable
allowunstable = obsolete.isenabled(repo, obsolete.allowunstableopt)
if allowunstable:
return revset.baseset()
return repo.revs("(%ld::) - %ld", revs, revs)