Page MenuHomePhabricator
Differential D1518

nodemap: move some methods to changelog utils
AbandonedPublic
Actions

Authored by quark on Nov 27 2017, 1:30 PM.

Details

Reviewers
jsgf
Group Reviewers
Restricted Project
Summary

Those methods and constants will be reused by another module.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Nov 27 2017, 1:30 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2017, 1:30 PM
jsgf requested changes to this revision.Dec 7 2017, 12:25 PM
jsgf added a subscriber: jsgf.
jsgf added inline comments.
rust/indexes/src/nodemap.rs
222–225

(driveby) You can use b'a' to get a character value as a u8. so b'a'...b'f' => ch - b'a',, etc

rust/indexes/src/utils.rs
13 ↗(On Diff #3880)
if rev > i32::MAX as u64 {

You may need to use std::i32;

This revision now requires changes to proceed.Dec 7 2017, 12:25 PM
quark updated this revision to Diff 4455.Dec 14 2017, 9:21 PM
quark edited the summary of this revision. (Show Details)Dec 14 2017, 10:15 PM
quark retitled this revision from nodemap: move some methods to utils to nodemap: move some methods to changelog utils.
quark updated this revision to Diff 4461.
quark abandoned this revision.Dec 7 2019, 2:14 AM

No longer use this approach.

Revision Contents
Changeset List

Diff 4461

View Options

rust/indexes/src/changelog_utils.rs

Loading...
View Options

rust/indexes/src/lib.rs

Loading...
View Options

rust/indexes/src/nodemap.rs

Loading...