Abnormally huge packfiles (20 GB+) are unwanted and can cause more problems
than they solve. Let's add a config to simply delete them at the beginning of
the repack proces.
Details
Details
- Reviewers
durham - Group Reviewers
Restricted Project - Commits
- rFBHGXa3fa61f9c38f: repack: delete excessively big packfiles before incremental repack
Diff Detail
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
Based on yesterday's conversation, do we need to limit this to remotefilelog for now? @simpkins
remotefilelog/repack.py | ||
---|---|---|
289 | You can even remove the big files at this point. Something like if size > maxsize: # Delete the file elif size > limit: # Use the current code. Would reuse a lot of work. |
remotefilelog/repack.py | ||
---|---|---|
289 | I think this is the size of the index file, not the data file. |
I'd use ui.configbytes(...), that way users can specify values like '512M' and '20G'