Page MenuHomePhabricator

treedirstate: prevent interference with other dirstate implementations
ClosedPublic

Authored by mbthomas on Nov 28 2017, 5:38 AM.

Details

Summary

To avoid problems when other dirstate implementations are in use (sqldirstate
or eden), prevent upgrade of repos with those implementations active to
treedirstate.

Automatic upgrades are silently prevented. Attempts to manually upgrade fail
with an explanatory message.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Nov 28 2017, 5:38 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2017, 5:38 AM
stash requested changes to this revision.Nov 28 2017, 5:48 AM
stash added a subscriber: stash.

Ideally it would nice to have a test. Or at least can you add a test plan?

This revision now requires changes to proceed.Nov 28 2017, 5:48 AM
mbthomas updated this revision to Diff 3905.Nov 28 2017, 6:04 AM
stash accepted this revision.Nov 28 2017, 7:37 AM
stash added inline comments.
tests/test-treedirstate.t
187–190

How do you check here that there were no update?

This revision is now accepted and ready to land.Nov 28 2017, 7:37 AM
mbthomas added inline comments.Nov 28 2017, 7:39 AM
tests/test-treedirstate.t
187–190

It prints out migrating your repo to treedirstate... when it upgrades (see line 199 below)

This revision was automatically updated to reflect the committed changes.