Page MenuHomePhabricator

treedirstate: add integration tests
ClosedPublic

Authored by mbthomas on Nov 22 2017, 1:15 PM.

Details

Reviewers
stash
Group Reviewers
Restricted Project
Commits
rFBHGX341a0776470e: treedirstate: add integration tests
Summary

Copy the dirstate tests from core Mercurial, but run them with treedirstate
instead of the default dirstate map.

Add an extra test that covers scenarios specific to treedirstate.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Nov 22 2017, 1:15 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2017, 1:15 PM
quark added a subscriber: quark.EditedNov 22 2017, 2:03 PM

For copied tests: Have you tried running all core hg tests with ./run-tests.py --extra-config-opt=extensions.treedirstate= (make sure hg init create treedirstate repo)? Certain tests will fail (ex. those listing .hg/ or extensions) but it might give us some clues.

The added tests look good.

In D1490#25081, @quark wrote:

For copied tests: Have you tried running all core hg tests with ./run-tests.py --extra-config-opt=extensions.treedirstate=

Yes, I've run all of the tests in core mercurial with treedirstate enabled, and the ones that fail do so for mundane reasons like enumerating extensions. I've updated this diff to include my blacklist file.

stash accepted this revision.Nov 27 2017, 4:53 AM
This revision is now accepted and ready to land.Nov 27 2017, 4:53 AM
mbthomas updated this revision to Diff 3892.Nov 27 2017, 4:33 PM
This revision was automatically updated to reflect the committed changes.