This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1533

setup: correct URL of repository
ClosedPublic

Authored by durin42 on Nov 28 2017, 2:36 PM.
Tags
None
Subscribers
None

Details

Reviewers
martinvonz
spectral
Commits
rNRWHG60089e990fdf: setup: correct URL of repository

Diff Detail

Repository
rNRWHG narrowhg
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 28 2017, 2:36 PM
spectral added inline comments.Dec 5 2017, 2:26 PM
setup.py
22

We should probably fix these lines as well. :)

durin42 added inline comments.Dec 5 2017, 4:17 PM
setup.py
22

What would you like them to say? Probably ought to be a list or something that supports public posting?

spectral added inline comments.Dec 5 2017, 5:08 PM
setup.py
22

I have no idea. I believe they're supposed to be individuals, so I could do it if you need me to.

durin42 added inline comments.Dec 11 2017, 3:06 PM
setup.py
22

Since we all feel so strongly, D1661 points those fields at me.

Closed by commit rNRWHG60089e990fdf: setup: correct URL of repository (authored by durin42). · Explain WhyDec 11 2017, 4:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msetup.py (2 lines)

Diff 3913

setup.py

if re.match("^__version__ *= *'.*'", line): if re.match("^__version__ *= *'.*'", line):
if "'" in line: if "'" in line:
return line.split("'")[1] return line.split("'")[1]
setup( setup(
name='narrowhg', name='narrowhg',
version=get_version('src/__init__.py'), version=get_version('src/__init__.py'),
author='Michael Edgar', author='Michael Edgar',
maintainer='Michael Edgar', maintainer='Michael Edgar',
spectralUnsubmitted
Not Done

We should probably fix these lines as well. :)

spectral: We should probably fix these lines as well. :)
durin42AuthorUnsubmitted
Not Done

What would you like them to say? Probably ought to be a list or something that supports public posting?

durin42: What would you like them to say? Probably ought to be a list or something that supports public…
spectralUnsubmitted
Not Done

I have no idea. I believe they're supposed to be individuals, so I could do it if you need me to.

spectral: I have no idea. I believe they're supposed to be individuals, so I could do it if you need me…
durin42AuthorUnsubmitted
Not Done

Since we all feel so strongly, D1661 points those fields at me.

durin42: Since we all feel so strongly, D1661 points those fields at me.
maintainer_email='adgar@google.com', maintainer_email='adgar@google.com',
url='https://bitbucket.org/michaeljedgar/narrowhg/', url='https://bitbucket.org/Google/narrowhg/',
description='Narrow clones of Mercurial history.', description='Narrow clones of Mercurial history.',
long_description=open('README.md').read(), long_description=open('README.md').read(),
keywords='hg mercurial', keywords='hg mercurial',
license='GPLv2+', license='GPLv2+',
packages=['narrowhg'], packages=['narrowhg'],
package_dir={'narrowhg': 'src'}, package_dir={'narrowhg': 'src'},
) )