This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1553

contrib: improve check-code ban on $LOCALIP in output without (glob)
ClosedPublic

Authored by durin42 on Nov 29 2017, 5:09 PM.

Details

Reviewers
lothiraldan
yuja
Group Reviewers
hg-reviewers
Commits
rHG273907306a39: contrib: improve check-code ban on $LOCALIP in output without (glob)
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 29 2017, 5:09 PM
lothiraldan accepted this revision.Nov 29 2017, 7:19 PM
lothiraldan added a subscriber: lothiraldan.

Looks good, thank you for the fix.

yuja accepted this revision.Nov 30 2017, 7:37 AM
This revision is now accepted and ready to land.Nov 30 2017, 7:37 AM
Closed by commit rHG273907306a39: contrib: improve check-code ban on $LOCALIP in output without (glob) (authored by durin42). · Explain WhyNov 30 2017, 7:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (2 lines)

Diff 4010

contrib/check-code.py

(r'^ pushing subrepo \S+/\S+ to.*[^)]$', winglobmsg), (r'^ pushing subrepo \S+/\S+ to.*[^)]$', winglobmsg),
(r'^ moving \S+/.*[^)]$', winglobmsg), (r'^ moving \S+/.*[^)]$', winglobmsg),
(r'^ no changes made to subrepo since.*/.*[^)]$', winglobmsg), (r'^ no changes made to subrepo since.*/.*[^)]$', winglobmsg),
(r'^ .*: largefile \S+ not available from file:.*/.*[^)]$', winglobmsg), (r'^ .*: largefile \S+ not available from file:.*/.*[^)]$', winglobmsg),
(r'^ .*file://\$TESTTMP', (r'^ .*file://\$TESTTMP',
'write "file:/*/$TESTTMP" + (glob) to match on windows too'), 'write "file:/*/$TESTTMP" + (glob) to match on windows too'),
(r'^ [^$>].*27\.0\.0\.1', (r'^ [^$>].*27\.0\.0\.1',
'use $LOCALIP not an explicit loopback address'), 'use $LOCALIP not an explicit loopback address'),
(r'^ [^$>].*\$LOCALIP.*[^)]$', (r'^ (?![>$] ).*\$LOCALIP.*[^)]$',
'mark $LOCALIP output lines with (glob) to help tests in BSD jails'), 'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),
(r'^ (cat|find): .*: No such file or directory', (r'^ (cat|find): .*: No such file or directory',
'use test -f to test for file existence'), 'use test -f to test for file existence'),
(r'^ diff -[^ -]*p', (r'^ diff -[^ -]*p',
"don't use (external) diff with -p for portability"), "don't use (external) diff with -p for portability"),
(r' readlink ', 'use readlink.py instead of readlink'), (r' readlink ', 'use readlink.py instead of readlink'),
(r'^ [-+][-+][-+] .* [-+]0000 \(glob\)', (r'^ [-+][-+][-+] .* [-+]0000 \(glob\)',
"glob timezone field in diff output for portability"), "glob timezone field in diff output for portability"),