This allows us to log what nodes are pinned by what commands. So we can
manually investigate what was happening when we get user complaints.
Details
Details
- Reviewers
durham stash - Group Reviewers
Restricted Project - Commits
- rFBHGX77e840e8c8c7: hiddenoverride: optionally log details
Diff Detail
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
hgext3rd/fbamend/hiddenoverride.py | ||
---|---|---|
101–102 | loadpinnednodes returns generator. So in this case it outputs empty list. There are two ways to fix it - use list(loadpinnednodes(repo)) here or return list instead of generator in loadpinnednodes. I vote for latter | |
tests/test-fbamend-hiddenoverride.t | ||
63–93 | before is always []. It's incorrect, isn't it? And I think I know what's the problem, see above |
hgext3rd/fbamend/hiddenoverride.py | ||
---|---|---|
101–102 | Good catch! |
Comment Actions
I'm pushing this in the hope that it helps identify related issues if we got related complaints again. We have rolled back too many times this week and I'd like to get some clues at least next time.
loadpinnednodes returns generator. So in this case it outputs empty list. There are two ways to fix it - use list(loadpinnednodes(repo)) here or return list instead of generator in loadpinnednodes. I vote for latter