Page MenuHomePhabricator

tests_: fix test-lfs.t on OSX where find does not have quotes
AbandonedPublic

Authored by ikostia on Dec 12 2017, 2:42 PM.

Details

Reviewers
quark
akushner
Group Reviewers
hg-reviewers
Test Plan
  • run test-lfs.t

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

ikostia created this revision.Dec 12 2017, 2:42 PM
quark accepted this revision.Dec 12 2017, 2:43 PM
akushner accepted this revision.Dec 12 2017, 3:13 PM
akushner added a subscriber: akushner.

Why was there a quote on Linux? I didn't see a quote when I ran the find command.

quark added a comment.Dec 12 2017, 4:34 PM

Why was there a quote on Linux? I didn't see a quote when I ran the find command.

coreutils (starting from some version) added quotes by default if it finds special characters in paths: https://unix.stackexchange.com/questions/258679/why-is-ls-suddenly-wrapping-items-with-spaces-in-single-quotes

I think some distros have that disabled by default.

(and yes, I'm curious where that ' came from too, but here we are)

quark added a comment.Dec 12 2017, 4:36 PM

@ikostia This Phabricator instance should support "tests:" in title so there is no need to workaround that by using an underscore.

ikostia abandoned this revision.Dec 13 2017, 5:24 AM

@quark: thanks for the tests note.

abandoning this as an equivalent change is already landed.