This is an archive of the discontinued Mercurial Phabricator instance.

Differential D166

perftweaks: add update sizes to logging
ClosedPublic

Authored by durham on Jul 21 2017, 7:57 AM.
Tags
None
Subscribers
ryanmce

Details

Reviewers
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGXb44eead1f0e2: perftweaks: add update sizes to logging
Summary

Let's log the number of commits we're traversing and the number of files
changed by an update.

Test Plan

Ran it with --config
sampling.key.update_size=perfpipe_dev_command_timers and watched the entry show
up via ptail

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Test Errors

Event Timeline

durham created this revision.Jul 21 2017, 7:57 AM
ryanmce accepted this revision.Jul 21 2017, 8:17 AM
ryanmce added a subscriber: ryanmce.

Noice

This revision is now accepted and ready to land.Jul 21 2017, 8:17 AM
Closed by commit rFBHGXb44eead1f0e2: perftweaks: add update sizes to logging (authored by durham). · Explain WhyJul 31 2017, 1:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/perftweaks.py (10 lines)

Diff 358

hgext3rd/perftweaks.py

wrapfunction(tags, '_readtagcache', _readtagcache) wrapfunction(tags, '_readtagcache', _readtagcache)
wrapfunction(merge, '_checkcollision', _checkcollision) wrapfunction(merge, '_checkcollision', _checkcollision)
wrapfunction(branchmap.branchcache, 'update', _branchmapupdate) wrapfunction(branchmap.branchcache, 'update', _branchmapupdate)
if ui.configbool('perftweaks', 'preferdeltas'): if ui.configbool('perftweaks', 'preferdeltas'):
wrapfunction(revlog.revlog, '_isgooddelta', _isgooddelta) wrapfunction(revlog.revlog, '_isgooddelta', _isgooddelta)
wrapfunction(dispatch, 'runcommand', _trackdirstatesizes) wrapfunction(dispatch, 'runcommand', _trackdirstatesizes)
wrapfunction(dispatch, 'runcommand', _tracksparseprofiles) wrapfunction(dispatch, 'runcommand', _tracksparseprofiles)
wrapfunction(merge, 'update', _trackupdatesize)
# noderev cache creation # noderev cache creation
# The node rev cache is a cache of rev numbers that we are likely to do a # The node rev cache is a cache of rev numbers that we are likely to do a
# node->rev lookup for. Since looking up rev->node is cheaper than # node->rev lookup for. Since looking up rev->node is cheaper than
# node->rev, we use this cache to prefill the changelog radix tree with # node->rev, we use this cache to prefill the changelog radix tree with
# mappings. # mappings.
wrapfunction(branchmap.branchcache, 'write', _branchmapwrite) wrapfunction(branchmap.branchcache, 'write', _branchmapwrite)
wrapfunction(phases.phasecache, 'advanceboundary', _editphases) wrapfunction(phases.phasecache, 'advanceboundary', _editphases)
def _tracksparseprofiles(runcommand, lui, repo, *args): def _tracksparseprofiles(runcommand, lui, repo, *args):
res = runcommand(lui, repo, *args) res = runcommand(lui, repo, *args)
if repo is not None and repo.local(): if repo is not None and repo.local():
if util.safehasattr(repo, 'getactiveprofiles'): if util.safehasattr(repo, 'getactiveprofiles'):
profiles = repo.getactiveprofiles() profiles = repo.getactiveprofiles()
lui.log('sparse_profiles', '', lui.log('sparse_profiles', '',
active_profiles=','.join(sorted(profiles))) active_profiles=','.join(sorted(profiles)))
return res return res
def _trackupdatesize(orig, repo, node, branchmerge, *args, **kwargs):
if not branchmerge:
revs = repo.revs('(%s %% .) + (. %% %s)', node, node)
repo.ui.log('update_size', '', update_commitcount=len(revs))
stats = orig(repo, node, branchmerge, *args, **kwargs)
repo.ui.log('update_size', '', update_filecount=sum(stats))
return stats