This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1691

debugdiscovery: drop reference to invalid --branch option
ClosedPublic

Authored by martinvonz on Dec 14 2017, 6:35 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG2105bdd9462a: debugdiscovery: drop reference to invalid --branch option
Summary

It seems like it didn't even exist when debugdiscovery was introduced
in cb98fed52495 (discovery: add new set-based discovery, 2011-05-02).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Dec 14 2017, 6:35 PM
yuja accepted this revision.Dec 15 2017, 8:25 AM
This revision is now accepted and ready to land.Dec 15 2017, 8:25 AM
Closed by commit rHG2105bdd9462a: debugdiscovery: drop reference to invalid --branch option (authored by martinvonz). · Explain WhyDec 15 2017, 8:52 AM
This revision was automatically updated to reflect the committed changes.
krbullock added a subscriber: krbullock.Dec 15 2017, 11:18 AM
krbullock added inline comments.
mercurial/debugcommands.py
747

Drop [-b BRANCH] from the usage string above too?

martinvonz added inline comments.Dec 15 2017, 11:44 AM
mercurial/debugcommands.py
747

Sure, will send a separate patch

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (3 lines)

Diff 4440

mercurial/debugcommands.py

('', 'nonheads', None, ('', 'nonheads', None,
_('use old-style discovery with non-heads included')), _('use old-style discovery with non-heads included')),
('', 'rev', [], 'restrict discovery to this set of revs'), ('', 'rev', [], 'restrict discovery to this set of revs'),
] + cmdutil.remoteopts, ] + cmdutil.remoteopts,
_('[-l REV] [-r REV] [-b BRANCH]... [OTHER]')) _('[-l REV] [-r REV] [-b BRANCH]... [OTHER]'))
def debugdiscovery(ui, repo, remoteurl="default", **opts): def debugdiscovery(ui, repo, remoteurl="default", **opts):
"""runs the changeset discovery protocol in isolation""" """runs the changeset discovery protocol in isolation"""
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
remoteurl, branches = hg.parseurl(ui.expandpath(remoteurl), remoteurl, branches = hg.parseurl(ui.expandpath(remoteurl))
krbullockUnsubmitted
Not Done

Drop [-b BRANCH] from the usage string above too?

krbullock: Drop `[-b BRANCH]` from the usage string above too?
martinvonzAuthorUnsubmitted
Not Done

Sure, will send a separate patch

martinvonz: Sure, will send a separate patch
opts.get('branch'))
remote = hg.peer(repo, opts, remoteurl) remote = hg.peer(repo, opts, remoteurl)
ui.status(_('comparing with %s\n') % util.hidepassword(remoteurl)) ui.status(_('comparing with %s\n') % util.hidepassword(remoteurl))
# make sure tests are repeatable # make sure tests are repeatable
random.seed(12323) random.seed(12323)
def doit(pushedrevs, remoteheads, remote=remote): def doit(pushedrevs, remoteheads, remote=remote):
if opts.get('old'): if opts.get('old'):