( )⚙ D1704 infinitepush: add backingup templatekeyword

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1704

infinitepush: add backingup templatekeyword
ClosedPublic

Authored by mbthomas on Dec 15 2017, 10:52 AM.
Tags
None
Subscribers
None

Details

Reviewers
stash
Group Reviewers
Restricted Project
Commits
rFBHGXdf07a778ff29: infinitepush: add backingup templatekeyword
Summary

Add a templatekeyword backingup which evaluates to True if infinitepush is
currently performing a background backup. This allows log output to be
customized for not-backed-up revisions if a backup is currently in progress.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Dec 15 2017, 10:52 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2017, 10:52 AM
stash accepted this revision.Dec 15 2017, 12:07 PM
This revision is now accepted and ready to land.Dec 15 2017, 12:07 PM
Closed by commit rFBHGXdf07a778ff29: infinitepush: add backingup templatekeyword (authored by mbthomas). · Explain WhyDec 15 2017, 2:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4499

infinitepush/__init__.py

experimental = 'experimental' experimental = 'experimental'
configbookmark = 'server-bundlestore-bookmark' configbookmark = 'server-bundlestore-bookmark'
configcreate = 'server-bundlestore-create' configcreate = 'server-bundlestore-create'
configscratchpush = 'infinitepush-scratchpush' configscratchpush = 'infinitepush-scratchpush'
confignonforwardmove = 'non-forward-move' confignonforwardmove = 'non-forward-move'
cmdtable = infinitepushcommands.cmdtable cmdtable = infinitepushcommands.cmdtable
revsetpredicate = backupcommands.revsetpredicate revsetpredicate = backupcommands.revsetpredicate
templatekeyword = backupcommands.templatekeyword
_scratchbranchmatcher = lambda x: False _scratchbranchmatcher = lambda x: False
_maybehash = re.compile(r'^[a-f0-9]+$').search _maybehash = re.compile(r'^[a-f0-9]+$').search
def _buildexternalbundlestore(ui): def _buildexternalbundlestore(ui):
put_args = ui.configlist('infinitepush', 'put_args', []) put_args = ui.configlist('infinitepush', 'put_args', [])
put_binary = ui.config('infinitepush', 'put_binary') put_binary = ui.config('infinitepush', 'put_binary')
if not put_binary: if not put_binary:
raise error.Abort('put binary is not specified') raise error.Abort('put binary is not specified')

infinitepush/backupcommands.py

from hgext3rd import shareutil from hgext3rd import shareutil
osutil = policy.importmod(r'osutil') osutil = policy.importmod(r'osutil')
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
revsetpredicate = registrar.revsetpredicate() revsetpredicate = registrar.revsetpredicate()
templatekeyword = registrar.templatekeyword()
backupbookmarktuple = namedtuple('backupbookmarktuple', backupbookmarktuple = namedtuple('backupbookmarktuple',
['hostname', 'reporoot', 'localbookmark']) ['hostname', 'reporoot', 'localbookmark'])
class backupstate(object): class backupstate(object):
def __init__(self): def __init__(self):
self.heads = set() self.heads = set()
self.localbookmarks = {} self.localbookmarks = {}
candidate = candidates.pop() candidate = candidates.pop()
if candidate in unfi: if candidate in unfi:
ctx = unfi[candidate] ctx = unfi[candidate]
if ctx.phase() != phases.public: if ctx.phase() != phases.public:
notbackeduprevs.discard(ctx.rev()) notbackeduprevs.discard(ctx.rev())
candidates.update([p.hex() for p in ctx.parents()]) candidates.update([p.hex() for p in ctx.parents()])
return subset & notbackeduprevs return subset & notbackeduprevs
@templatekeyword('backingup')
def backingup(repo, ctx, **args):
"""Whether infinitepush is currently backing up commits."""
# If the backup lock exists then a backup should be in progress.
srcrepo = shareutil.getsrcrepo(repo)
return srcrepo.vfs.lexists(_backuplockname)
def smartlogsummary(ui, repo): def smartlogsummary(ui, repo):
if not ui.configbool('infinitepushbackup', 'enablestatus'): if not ui.configbool('infinitepushbackup', 'enablestatus'):
return return
unbackeduprevs = repo.revs('notbackedup()') unbackeduprevs = repo.revs('notbackedup()')
# Count the number of changesets that haven't been backed up for 10 minutes. # Count the number of changesets that haven't been backed up for 10 minutes.
# If there is only one, also print out its hash. # If there is only one, also print out its hash.

tests/test-infinitepush-backup-status.t

$ echo b > file2 $ echo b > file2
$ commit_time=`expr $now - 11 \* 60` $ commit_time=`expr $now - 11 \* 60`
$ hg commit -d "$commit_time 0" -m "Not backed up changeset 3" $ hg commit -d "$commit_time 0" -m "Not backed up changeset 3"
$ hg log -T '{rev} {desc}\n' -r 'notbackedup()' $ hg log -T '{rev} {desc}\n' -r 'notbackedup()'
4 Not backed up changeset 4 Not backed up changeset
5 Backup pending changeset 5 Backup pending changeset
6 Not backed up changeset 2 6 Not backed up changeset 2
7 Not backed up changeset 3 7 Not backed up changeset 3
Test template keyword for when a backup is in progress
$ hg log -T '{if(backingup,"Yes","No")}\n' -r .
No
$ echo fakelock > .hg/infinitepushbackup.lock
$ hg log -T '{if(backingup,"Yes","No")}\n' -r .
Yes
$ rm -f .hg/infinitepushbackup.lock