This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1705

infinitepush: don't show backup summary if a backup is in progress
ClosedPublic

Authored by mbthomas on Dec 15 2017, 11:20 AM.
Tags
None
Subscribers
None

Details

Reviewers
stash
Group Reviewers
Restricted Project
Commits
rFBHGXb61e79aec430: infinitepush: don't show backup summary if a backup is in progress
Summary

If a backup is in progress (the backup lock is taken), we shouldn't show the
backup summary message as it will soon be out-of-date.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Dec 15 2017, 11:20 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2017, 11:20 AM
stash accepted this revision.Dec 15 2017, 12:18 PM
This revision is now accepted and ready to land.Dec 15 2017, 12:18 PM
Closed by commit rFBHGXb61e79aec430: infinitepush: don't show backup summary if a backup is in progress (authored by mbthomas). · Explain WhyDec 15 2017, 2:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minfinitepush/backupcommands.py (5 lines)

Diff 4500

infinitepush/backupcommands.py

# If the backup lock exists then a backup should be in progress. # If the backup lock exists then a backup should be in progress.
srcrepo = shareutil.getsrcrepo(repo) srcrepo = shareutil.getsrcrepo(repo)
return srcrepo.vfs.lexists(_backuplockname) return srcrepo.vfs.lexists(_backuplockname)
def smartlogsummary(ui, repo): def smartlogsummary(ui, repo):
if not ui.configbool('infinitepushbackup', 'enablestatus'): if not ui.configbool('infinitepushbackup', 'enablestatus'):
return return
# Don't output the summary if a backup is currently in progress.
srcrepo = shareutil.getsrcrepo(repo)
if srcrepo.vfs.lexists(_backuplockname):
return
unbackeduprevs = repo.revs('notbackedup()') unbackeduprevs = repo.revs('notbackedup()')
# Count the number of changesets that haven't been backed up for 10 minutes. # Count the number of changesets that haven't been backed up for 10 minutes.
# If there is only one, also print out its hash. # If there is only one, also print out its hash.
backuptime = time.time() - 10 * 60 # 10 minutes ago backuptime = time.time() - 10 * 60 # 10 minutes ago
count = 0 count = 0
singleunbackeduprev = None singleunbackeduprev = None
for rev in unbackeduprevs: for rev in unbackeduprevs: