Page MenuHomePhabricator

indexes: add comment indication location of python27-sys
ClosedPublic

Authored by mbthomas on Dec 18 2017, 6:42 AM.

Details

Summary

The indexes module depends directly on the python27-sys crate for low-level
manipulation of Python structures. This is located in a subdir in the cpython
git repository.

While that works for git repositories, this causes problems when the crate is
vendored, as Cargo is no longer able to find the directory.

Add a comment to the git URL line with the name of the subdirectory. This will
be used by the build script to locate the vendored version of the crate.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mbthomas created this revision.Dec 18 2017, 6:42 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2017, 6:42 AM
ikostia accepted this revision.Dec 18 2017, 6:53 AM

I just want people to know that this is not good.

This revision is now accepted and ready to land.Dec 18 2017, 6:53 AM

I'm willing to entertain better suggestions, but until Cargo has proper support for vendoring git repositories, we're stuck with an ugly hack.

quark accepted this revision.Dec 18 2017, 1:57 PM
quark added a subscriber: quark.

Thanks! I did not notice this since make local worked. I'm still not very sure about how cargo works in this case.

quark added a comment.Dec 18 2017, 3:10 PM

Turned out that I have proxy setup in the global git config so I was not able to reproduce this using make local.

This revision was automatically updated to reflect the committed changes.