This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1719

debug: remove an 'if ui.debug()' that is not doing anything
ClosedPublic

Authored by spectral on Dec 18 2017, 8:48 PM.

Details

Reviewers
krbullock
Group Reviewers
hg-reviewers
Commits
rHG3bb1a647ab42: debug: remove an 'if ui.debug()' that is not doing anything
Summary

ui.debug() does not return a value.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Dec 18 2017, 8:48 PM
quark added a subscriber: quark.Dec 18 2017, 10:48 PM

I think it should be ui.debugflag.

spectral added a comment.Dec 18 2017, 11:00 PM
In D1719#29390, @quark wrote:

I think it should be ui.debugflag.

I agree that's probably what was intended, but is it helpful to have it if it's never once been activated in 5 years? (added: 4bec77e62c00, 2012-12-13). (Ironically, if I ever actually ran this command I'd probably want it to have the behavior I'm deleting, but considering no one else has wanted it enough to fix the issue here, it feels too much like dead code/YAGNI for my tastes)

krbullock accepted this revision.Dec 21 2017, 5:50 PM
krbullock added a subscriber: krbullock.

Seems reasonable.

This revision is now accepted and ready to land.Dec 21 2017, 5:50 PM
Closed by commit rHG3bb1a647ab42: debug: remove an 'if ui.debug()' that is not doing anything (authored by spectral). · Explain WhyDec 21 2017, 6:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (4 lines)

Diff 4573

mercurial/debugcommands.py

Here rev2 has two possible (i.e. divergent) successors sets. The first Here rev2 has two possible (i.e. divergent) successors sets. The first
holds one element, whereas the second holds three (i.e. the changeset has holds one element, whereas the second holds three (i.e. the changeset has
been split). been split).
""" """
# passed to successorssets caching computation from one call to another # passed to successorssets caching computation from one call to another
cache = {} cache = {}
ctx2str = str ctx2str = str
node2str = short node2str = short
if ui.debug():
def ctx2str(ctx):
return ctx.hex()
node2str = hex
for rev in scmutil.revrange(repo, revs): for rev in scmutil.revrange(repo, revs):
ctx = repo[rev] ctx = repo[rev]
ui.write('%s\n'% ctx2str(ctx)) ui.write('%s\n'% ctx2str(ctx))
for succsset in obsutil.successorssets(repo, ctx.node(), for succsset in obsutil.successorssets(repo, ctx.node(),
closest=opts[r'closest'], closest=opts[r'closest'],
cache=cache): cache=cache):
if succsset: if succsset:
ui.write(' ') ui.write(' ')