This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1732

revsetlang: add utility function to return hash like symbols from the tree
ClosedPublic

Authored by pulkit on Dec 19 2017, 7:09 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGdd911f95cbda: revsetlang: add utility function to return hash like symbols from the tree
Summary

Functionalities like unhiding changesets whose rev/hash is passed by the user
required the knowledge of rev/hashes in the user provided specs. This patch adds
functions which can parse tree object and return a list of such values.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Dec 19 2017, 7:09 AM
yuja requested changes to this revision.Dec 19 2017, 9:09 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/revsetlang.py
665

Nit: _hashre to mark it a private.

674

Nit: could be a doctest.

679

My two cents, test if _ishashlikesymbol(s) here and early-return
[tree[1]].

The last [s for s ...] doesn't make sense.

This revision now requires changes to proceed.Dec 19 2017, 9:09 AM
pulkit updated this revision to Diff 4583.Dec 22 2017, 12:56 PM
yuja requested changes to this revision.Dec 25 2017, 8:06 AM
yuja added inline comments.
mercurial/revsetlang.py
665

Oops, one more thing. Needs $ to match whole word.

Test something like ('symbol', 'abe3ffZ').

691

Nit: this comment should be removed.

This revision now requires changes to proceed.Dec 25 2017, 8:06 AM
pulkit updated this revision to Diff 4608.Dec 25 2017, 10:08 AM
yuja accepted this revision.Dec 26 2017, 8:43 AM
This revision is now accepted and ready to land.Dec 26 2017, 8:43 AM
Closed by commit rHGdd911f95cbda: revsetlang: add utility function to return hash like symbols from the tree (authored by pulkit). · Explain WhyDec 26 2017, 9:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revsetlang.py (23 lines)

Diff 4551

mercurial/revsetlang.py

return set() return set()
else: else:
funcs = set() funcs = set()
for s in tree[1:]: for s in tree[1:]:
funcs |= funcsused(s) funcs |= funcsused(s)
if tree[0] == 'func': if tree[0] == 'func':
funcs.add(tree[1][1]) funcs.add(tree[1][1])
return funcs return funcs
hashre = util.re.compile('[0-9a-fA-F]{1,40}')
yujaUnsubmitted
Not Done

Nit: _hashre to mark it a private.

yuja: Nit: `_hashre` to mark it a private.
yujaUnsubmitted
Not Done

Oops, one more thing. Needs $ to match whole word.

Test something like ('symbol', 'abe3ffZ').

yuja: Oops, one more thing. Needs `$` to match whole word. Test something like `('symbol'…
def _ishashlikesymbol(symbol):
"""returns true if the symbol looks like a hash"""
return hashre.match(symbol)
def gethashlikesymbols(tree):
"""returns the list of symbols of the tree that look like hashes
for example for the revset 3::abe3ff it will return ('3', 'abe3ff')"""
yujaUnsubmitted
Not Done

Nit: could be a doctest.

yuja: Nit: could be a doctest.
if not tree:
return []
results = []
if tree[0] == "symbol":
yujaUnsubmitted
Not Done

My two cents, test if _ishashlikesymbol(s) here and early-return
[tree[1]].

The last [s for s ...] doesn't make sense.

yuja: My two cents, test `if _ishashlikesymbol(s)` here and early-return `[tree[1]]`. The last `[s…
results.append(tree[1])
elif len(tree) >= 3:
for subtree in tree[1:]:
results += gethashlikesymbols(subtree)
# return directly, we don't need to filter symbols again
return results
return [s for s in results if _ishashlikesymbol(s)]
yujaUnsubmitted
Not Done

Nit: this comment should be removed.

yuja: Nit: this comment should be removed.