This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1734

repoview: add a new filtername for accessing hidden commits
ClosedPublic

Authored by pulkit on Dec 19 2017, 7:10 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG07fdac1d5c66: repoview: add a new filtername for accessing hidden commits
Summary

This patch adds a new filter 'visible-hidden' for repository and will be used to
return a repo object with user passed revisions unhidden. Unlike the
directaccess extension in fb-hgext and previous series adding the functionality,
this time we introduce only one new filter as whether to warn user or not is
handled by scmutil.unhidehashlikerevs().

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Dec 19 2017, 7:10 AM
yuja added a subscriber: yuja.Dec 19 2017, 9:19 AM

This should come before D1733?

pulkit updated this revision to Diff 4584.Dec 22 2017, 12:57 PM
pulkit updated this revision to Diff 4609.Dec 25 2017, 10:08 AM
yuja accepted this revision.Dec 26 2017, 8:43 AM
This revision is now accepted and ready to land.Dec 26 2017, 8:43 AM
Closed by commit rHG07fdac1d5c66: repoview: add a new filtername for accessing hidden commits (authored by pulkit). · Explain WhyDec 26 2017, 9:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (1 line)
Mmercurial/repoview.py (1 line)

Diff 4553

mercurial/branchmap.py

### Nearest subset relation ### Nearest subset relation
# Nearest subset of filter X is a filter Y so that: # Nearest subset of filter X is a filter Y so that:
# * Y is included in X, # * Y is included in X,
# * X - Y is as small as possible. # * X - Y is as small as possible.
# This create and ordering used for branchmap purpose. # This create and ordering used for branchmap purpose.
# the ordering may be partial # the ordering may be partial
subsettable = {None: 'visible', subsettable = {None: 'visible',
'visible-hidden': 'visible',
'visible': 'served', 'visible': 'served',
'served': 'immutable', 'served': 'immutable',
'immutable': 'base'} 'immutable': 'base'}
def updatecache(repo): def updatecache(repo):
cl = repo.changelog cl = repo.changelog
filtername = repo.filtername filtername = repo.filtername
partial = repo._branchcaches.get(filtername) partial = repo._branchcaches.get(filtername)

mercurial/repoview.py

# function and visibility exceptions to compute filtered set # function and visibility exceptions to compute filtered set
# #
# When adding a new filter you MUST update the table at: # When adding a new filter you MUST update the table at:
# mercurial.branchmap.subsettable # mercurial.branchmap.subsettable
# Otherwise your filter will have to recompute all its branches cache # Otherwise your filter will have to recompute all its branches cache
# from scratch (very slow). # from scratch (very slow).
filtertable = {'visible': (computehidden, set()), filtertable = {'visible': (computehidden, set()),
'visible-hidden': (computehidden, set()),
'served': (computeunserved, set()), 'served': (computeunserved, set()),
'immutable': (computemutable, set()), 'immutable': (computemutable, set()),
'base': (computeimpactable, set())} 'base': (computeimpactable, set())}
def filterrevs(repo, filtername): def filterrevs(repo, filtername):
"""returns set of filtered revision for this filter name""" """returns set of filtered revision for this filter name"""
if filtername not in repo.filteredrevcache: if filtername not in repo.filteredrevcache:
func, visibilityexceptions = filtertable[filtername] func, visibilityexceptions = filtertable[filtername]