( )⚙ D1746 repoview: add visibilityexceptions as an optional argument to repo.filtered()

This is an archive of the discontinued Mercurial Phabricator instance.

repoview: add visibilityexceptions as an optional argument to repo.filtered()
ClosedPublic

Authored by pulkit on Dec 22 2017, 12:56 PM.

Details

Summary

This will help us in having an API where we can pass the filtername and the
visibilityexceptions to get a new repo object.

Visibility exceptions are the revs which must be visible even they should in
theory belong to the hidden set. They are required as there has been desire to
have a functionality to access hidden changesets using certain commands without
passing --hidden. After this patch we can make those changesets visibility
exceptions so that we can access them without requiring a unfiltered repo.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Dec 22 2017, 12:56 PM
yuja requested changes to this revision.Dec 25 2017, 7:49 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/repoview.py
196

We have to use object.__setattr__() because __setattr__() is
proxied to the unfilteredrepo.

This revision now requires changes to proceed.Dec 25 2017, 7:49 AM
pulkit updated this revision to Diff 4606.Dec 25 2017, 10:08 AM
yuja accepted this revision.Dec 26 2017, 8:42 AM
This revision is now accepted and ready to land.Dec 26 2017, 8:42 AM
This revision was automatically updated to reflect the committed changes.