This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1761

scmutil: use a tuple of possible values instead of using startswith()
ClosedPublic

Authored by pulkit on Dec 26 2017, 2:16 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGb55a142f00c5: scmutil: use a tuple of possible values instead of using startswith()
Summary

This patch also adds a review comment which is helpful as inline comment.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Dec 26 2017, 2:16 PM
yuja accepted this revision.Dec 27 2017, 7:20 AM
This revision is now accepted and ready to land.Dec 27 2017, 7:20 AM
Closed by commit rHGb55a142f00c5: scmutil: use a tuple of possible values instead of using startswith() (authored by pulkit). · Explain WhyDec 27 2017, 7:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (4 lines)

Diff 4641

mercurial/scmutil.py

2) 'nowarn': don't warn while unhiding changesets 2) 'nowarn': don't warn while unhiding changesets
returns a repo object with the required changesets unhidden returns a repo object with the required changesets unhidden
""" """
if not repo.filtername or not repo.ui.configbool('experimental', if not repo.filtername or not repo.ui.configbool('experimental',
'directaccess'): 'directaccess'):
return repo return repo
if not repo.filtername.startswith('visible'): if repo.filtername not in ('visible', 'visible-hidden'):
return repo return repo
symbols = set() symbols = set()
for spec in specs: for spec in specs:
try: try:
tree = revsetlang.parse(spec) tree = revsetlang.parse(spec)
except error.ParseError: # will be reported by scmutil.revrange() except error.ParseError: # will be reported by scmutil.revrange()
continue continue
return repo return repo
if hiddentype == 'warn': if hiddentype == 'warn':
unfi = repo.unfiltered() unfi = repo.unfiltered()
revstr = ", ".join([pycompat.bytestr(unfi[l]) for l in revs]) revstr = ", ".join([pycompat.bytestr(unfi[l]) for l in revs])
repo.ui.warn(_("warning: accessing hidden changesets for write " repo.ui.warn(_("warning: accessing hidden changesets for write "
"operation: %s\n") % revstr) "operation: %s\n") % revstr)
# we have to use new filtername to separate branch/tags cache until we can
# disbale these cache when revisions are dynamically pinned.
return repo.filtered('visible-hidden', revs) return repo.filtered('visible-hidden', revs)
def _getrevsfromsymbols(repo, symbols): def _getrevsfromsymbols(repo, symbols):
"""parse the list of symbols and returns a set of revision numbers of hidden """parse the list of symbols and returns a set of revision numbers of hidden
changesets present in symbols""" changesets present in symbols"""
revs = set() revs = set()
unfi = repo.unfiltered() unfi = repo.unfiltered()
unficl = unfi.changelog unficl = unfi.changelog